Skip to content

fix: ensure validation is run on correct files#344

Merged
beckermr merged 10 commits into
conda-forge:mainfrom
beckermr:fix-output-val
Sep 18, 2024
Merged

fix: ensure validation is run on correct files#344
beckermr merged 10 commits into
conda-forge:mainfrom
beckermr:fix-output-val

Conversation

@beckermr

Copy link
Copy Markdown
Member

This PR ensures we run output validation only on the packages we built.

closes #342
closes #341

@conda-forge-webservices

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@beckermr

Copy link
Copy Markdown
Member Author

cc @isuruf

@beckermr beckermr marked this pull request as ready for review September 18, 2024 15:42
@beckermr beckermr requested a review from a team as a code owner September 18, 2024 15:42
Comment thread recipe/conda_forge_ci_setup/feedstock_outputs.py Outdated
Comment thread recipe/conda_forge_ci_setup/utils.py
Comment thread recipe/conda_forge_ci_setup/inspect_artifacts.py Outdated
@beckermr

Copy link
Copy Markdown
Member Author

ok @isuruf I've added caching and I added the options to the CI setup calls. They are not required right now. Once we adjust smithy, we can turn them to be required if we like.

@beckermr beckermr merged commit 3f80011 into conda-forge:main Sep 18, 2024
@beckermr beckermr deleted the fix-output-val branch September 18, 2024 19:00
@jaimergp

Copy link
Copy Markdown
Member

I think this broke inspect_artifacts in staged-recipes. Not sure why we need to render the recipes there (again). See here for Linux logs (fails but error is ignored):

Inspecting artifacts
+ command -v inspect_artifacts
+ inspect_artifacts
Error: non-existent: /home/conda/staged-recipes/recipe
+ echo 'inspect_artifacts needs conda-forge-ci-setup >=4.6.0'
inspect_artifacts needs conda-forge-ci-setup >=4.6.0

The Error: non-existent string comes from conda_build.render. I guess in staged-recipes we can't pass /recipe blindly, since the recipe dir depends on the PR contents.

@beckermr

Copy link
Copy Markdown
Member Author

Ah I see. The goal in this pr was to not print inspection for every artifact but only the ones that were new. When there are downstream tests, we inspect the downstreams too which is odd and confusing.

@jaimergp

Copy link
Copy Markdown
Member

Got it. I think we raaaarely use downstreams in staged-recipes, right? Should we special case it? Or adjust this so it accepts several directories and pass recipes/* from staged-recipes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Output validation fails when there are downstream tests some distributions not found

3 participants