This repository has been archived by the owner on Apr 9, 2020. It is now read-only.
Set the Mac OS X deployment target #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Looks good to me. This will need to be rebased to be merged through the GitHub UI. |
|
Yeah sort of figured PR ( #45 ) would be merged before this. |
|
Have rebased. |
Using `conda-build` 2 (2.0.12+), sets the Mac OS X target architecture using a whitelisted environment variable. This should provide a safe fallback that everyone can use whether or not they are using the `toolchain` currently.
|
cc @inducer |
|
After our meeting yesterday, it sounds like we are in agreement with this change. Going to go ahead and merge it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
conda-build2 (2.0.12+), sets the Mac OS X target architecture using a whitelisted environment variable. This should provide a safe fallback that everyone can use whether or not they are using thetoolchaincurrently.xref: conda/conda-build#1561
cc @msarahan