Skip to content

Update to 0.6.13 - #4

Closed
Anthchirp wants to merge 7 commits into
conda-forge:mainfrom
Anthchirp:update-0613
Closed

Anthchirp wants to merge 7 commits into
conda-forge:mainfrom
Anthchirp:update-0613

Conversation

@Anthchirp

@Anthchirp Anthchirp commented Oct 12, 2020

Copy link
Copy Markdown
Member

and pull sources from pypi which should make the automatic update
checking bot happy.

Checklist

and pull sources from pypi which should make the automatic update
checking bot happy.
@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@Anthchirp

Copy link
Copy Markdown
Member Author

@conda-forge-admin, please rerender

conda-forge-linter and others added 2 commits October 12, 2020 16:36
@Anthchirp

Anthchirp commented Oct 13, 2020

Copy link
Copy Markdown
Member Author

Okay kid, this is where it gets complicated. - Amy Pond

We have a cmake-format-feedstock (this one) and a cmake_format-feedstock. The package itself was recently renamed cmake-formatcmakelang. There are pypi packages for both cmake-format and cmakelang

The pypi cmake-format old-name, transitional package is broken: It doesn't just declare a dependency on the new package and be done with it, instead it tries to download the sources and do the actual installation. However, it tries to download the sources from a Github repository that doesn't exist. This is why the build above fails.

After a quick chat with the conda-forces PTB this is my proposed solution:

  • Keep this feedstock (cmake-format-feedstock)
  • Archive the other feedstock (cmake_format-feedstock)
  • Modify the recipe here to have 3 outputs:
    • cmake-format
    • cmake_format
    • cmakelang
  • The first two outputs only add a pinned dependency on the third (cmakelang) and are otherwise empty. They only serve to keep the old names alive.
  • The third output is the actual package, which will be derived from the cmakelang pypi package

We have a cmake-format-feedstock (this one) and a
cmake_format-feedstock. The package itself was recently renamed
cmake-format→cmakelang. There are pypi packages for both cmake-format
and cmakelang.

To address this we rewrite the recipe as follows:
* Keep this feedstock (cmake-format-feedstock)
* Archive the other feedstock (cmake_format-feedstock)
* Modify the recipe here to have 3 outputs:
  * cmake-format
  * cmake_format
  * cmakelang
* The first two outputs only add a pinned dependency on the third
  (cmakelang) and are otherwise empty. They only serve to keep the old
  names alive.
* The third output is the actual package, which will be derived from the
  cmakelang pypi package
@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The outputs section contained an unexpected subsection name. entry_points is not a valid subsection name.

add python to host requirements to maybe satisfy Jinja
@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@Anthchirp

Copy link
Copy Markdown
Member Author

The source distribution and setup script have a number of problems. Reported upstream at cheshirekow/cmake_format#233 and cheshirekow/cmake_format#234. The definition of multiple packages in a single setup.py is causing the build failure here.

@xhochy

xhochy commented Oct 14, 2020

Copy link
Copy Markdown
Member

If the new PyPI is now cmakelang, I would rather make a new feedstock and archive this one. This makes discoverability of the feedstock producing the package easier. Otherwise the plan sounds good and the bugs don't :(

@bdice

bdice commented Nov 6, 2020

Copy link
Copy Markdown

I'm also interested in this. I tried conda install -c conda-forge cmakelang and was going to help create it if it didn't exist, which led me here. I agree with @xhochy's recommendation to archive this feedstock and create a new one for easier discoverability of the feedstock.

@bdice

bdice commented Apr 16, 2022

Copy link
Copy Markdown

I opened a PR for a new recipe here and CI is passing. Only took 1.5 years. 🥳 conda-forge/staged-recipes#18686

Anthchirp added a commit to conda-forge/staged-recipes that referenced this pull request Apr 21, 2022
Add cmakelang recipe (package renamed from cmake-format).

Closes conda-forge/cmake-format-feedstock#4
@Anthchirp Anthchirp closed this Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants