Use conda-forge dependencies

[jakirkham]

Fixes #7

Tries to use conda-forge dependencies as much as possible instead of trying to use CMake internally built dependencies. This should speed up the build, improve portability, and fix various subtle issues like not having certs for curl.

This adds some dependencies, but some of them like bzip2 are not here at conda-forge yet. There are more dependencies we should add like expat and xz, which don't exist on Windows yet. There are some other dependencies like jsoncpp and libarchive, which are simply not packaged yet. (EDIT: everything is packaged on UNIX and added as a dependency) Finally, we still need to address pinnings here and probably add a test for using SSL. Other questions include whether we should build this with Qt support as that is an option and could be desirable in some cases.

Feedback welcome on the progress thus far and any of these points that still need to be addressed.

cc @patricksnape @msarahan

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[jakirkham]

Interesting, appears this uses ncurses too.

[jakirkham]

So, this is a pretty subtle point, but cmake looks for ncurses. However, it fails to find the cbreak function defined. Would suspect this is because it is not searching tinfo too. Need to figure out why and how to fix it.

[jakirkham]

After investigating the tinfo situation more closely, I think this is a false positive. Basically, cmake use to state it was searching tinfo for cbreak, but they decided to drop that with commit ( Kitware/CMake@b4005a3 ). As a result, it doesn't say it is searching for tinfo, but still tries to find and link against it for cbreak if needed. This still find cbreak, but simply doesn't announce it. The behavior can be verified by noting ccmake's linkage which includes tinfo.

[jakirkham]

This is ready to go on my end.

[patricksnape]

Did we confirm this fixes the SSL issues?

[jakirkham]

Not yet. Though curl is tested for downloading via SSL. That being said, I think we should be able to come up with a simple test and add it here.

[blowekamp]

Please consider adding the following:
--parallel=${CPU_COUNT}
--
-DCMAKE_BUILD_TYPE:STRING=Release \

[jakirkham]

The CPU_COUNT value tends to be inaccurate on the CIs. We have explored setting this through MAKEFLAGS in PR ( conda-forge/conda-forge-build-setup-feedstock#1 ). However, that turns out to be more trouble than it is worth and removal is thus being proposed in PR ( conda-forge/conda-forge-build-setup-feedstock#18 ). Ideally we will override CPU_COUNT so that it can be used responsibly, but we will need to get some other players on-board first.

[jakirkham]

See this issue ( conda/conda-build#1117 ) for overriding CPU_COUNT.

[blowekamp]

Anything I could to to help with this patch?

[jakirkham]

If you can come up with a test, for https that would be greatly appreciated, @blowekamp.

[blowekamp]

I took a stab at it here: blowekamp@c41ba77

HTH

[jakirkham]

Thanks @blowekamp. I made some tweaks to it, but have left you as author on that commit. It seems to work ok for me locally. Let's see what the CIs think.

[jakirkham]

Seems it passes that test.

[pelson]

This looks good to me. @blowekamp - are you interested in being added as a maintainer here?

[blowekamp]

Yes, I'll continue to help out with this recipe.

[jakirkham]

Thanks @blowekamp. Was thinking of asking the same thing. Have added you on. An email should be sent to you later that will ask you to join conda-forge (after this is merged).

[jakirkham]

@pelson, I was going to ask @msarahan to review, but if he is too busy I think this is ready to go. Nothing to surprising happened here and it has been tested.

[jakirkham]

Alright, @blowekamp @patricksnape the Linux and OS X builds of this are out in the wild. Windows builds are pending though there was no actionable change for them with this addition. You should be good to go. Please let me know if you run into any issues. Thanks for raising this and helping me resolve it. 😄

[patricksnape]

@jakirkham Still seeing this error for the OpenCV3 recipe.

Edit: Seems I'm not getting this build actually - any idea why I'm pulling build 3 rather than build 4?