Skip to content

[20.x] Add patches for ROOT 6.38.00#401

Merged
h-vetinari merged 2 commits into
conda-forge:20.xfrom
vepadulano:20.x-root63800
Nov 29, 2025
Merged

[20.x] Add patches for ROOT 6.38.00#401
h-vetinari merged 2 commits into
conda-forge:20.xfrom
vepadulano:20.x-root63800

Conversation

@vepadulano

Copy link
Copy Markdown
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin

conda-forge-admin commented Nov 27, 2025

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19757094887. Examine the logs at this URL for more detail.

@h-vetinari h-vetinari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

It bears repeating though that clang 20 has a bunch of ABI breaks (especially in C++ containers), and we've tried avoid using this at scale, c.f. conda-forge/conda-forge-pinning-feedstock#7839

In other words, it's possible you'll get issues when you combine llvm-20-based root with packages built by llvm 19 or 21 (which fixed the ABI break)

Comment thread recipe/conda_build_config.yaml Outdated
…5.11.27.22.01.22

Other tools:
- conda-build 25.5.0
- rattler-build 0.44.0
- rattler-build-conda-compat 1.4.5
@vepadulano

Copy link
Copy Markdown
Contributor Author

@h-vetinari thank you for your comment, if we'll see some issues at least we know where to start looking from. Meanwhile, I removed the leftover comment from conda_build_config.yaml

@h-vetinari h-vetinari merged commit 2b0d701 into conda-forge:20.x Nov 29, 2025
14 checks passed

@h-vetinari h-vetinari Nov 29, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this file on the main branch in 7613f51, so we don't have to check this in anew every time root adds support for a version

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants