Skip to content

[main] switch to using libcxx-devel#311

Merged
isuruf merged 1 commit into
conda-forge:mainfrom
h-vetinari:devel
Aug 28, 2024
Merged

[main] switch to using libcxx-devel#311
isuruf merged 1 commit into
conda-forge:mainfrom
h-vetinari:devel

Conversation

@h-vetinari

Copy link
Copy Markdown
Member

For #310, using builds from conda-forge/libcxx-feedstock#183

@conda-forge-webservices

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@h-vetinari

h-vetinari commented Aug 27, 2024

Copy link
Copy Markdown
Member Author

@isuruf, could you please check this is what you had in mind?

@h-vetinari

Copy link
Copy Markdown
Member Author

Gentle ping @isuruf

@isuruf isuruf merged commit 878ed6a into conda-forge:main Aug 28, 2024
@isuruf

isuruf commented Aug 28, 2024

Copy link
Copy Markdown
Member

Thanks

Comment thread recipe/meta.yaml
- zstd
run:
- libstdcxx-devel_{{ target_platform }} # [linux]
- libcxx-devel # [osx]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to pin the version here. Sorry I missed this.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants