Skip to content

clangdev v13.0.0 (redux)#158

Merged
isuruf merged 8 commits into
conda-forge:masterfrom
h-vetinari:13.x
Nov 24, 2021
Merged

clangdev v13.0.0 (redux)#158
isuruf merged 8 commits into
conda-forge:masterfrom
h-vetinari:13.x

Conversation

@h-vetinari

Copy link
Copy Markdown
Member

Closes #157

Also add myself to maintainers as discussed here.

@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Comment thread recipe/meta.yaml
host:
- libcxx {{ cxx_compiler_version }} # [osx]
- llvmdev =={{ version }}
- zlib # [linux]

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isuruf, this is needed by build.sh before any of the outputs.

My question is: do we also need to add zlib to all of the outputs individually?

@h-vetinari h-vetinari Oct 5, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently following a minimal approach to add this only where needed (even though that takes a couple iterations).

@h-vetinari

Copy link
Copy Markdown
Member Author

OK, finally zlib added in enough places. For the python-bindings failure, I have very little to go on, though.

The upstream readme mentions setting CLANG_LIBRARY_PATH=$(llvm-config --libdir) (though that's not a recent change, i.e. no change from LLVM 12). Should we set this somewhere in the recipe?

@h-vetinari

Copy link
Copy Markdown
Member Author

Whaaa...? The build passed before on OSX, and now, with linux-only changes, it fails as well upon import.

The only candidate I can think of is that this is due to the python 3.10 builds that were merged today (which get pulled in due to noarch: python). @isuruf

@isuruf

isuruf commented Oct 6, 2021

Copy link
Copy Markdown
Member

Yes. See conda/conda#10969

@h-vetinari h-vetinari closed this Oct 14, 2021
@h-vetinari h-vetinari reopened this Oct 14, 2021
@h-vetinari

Copy link
Copy Markdown
Member Author

@isuruf, there's still something not working out with 3.10 (on osx).

With python 3.10:

+ python -m unittest discover -v
test_access_specifiers (tests.cindex.test_access_specifiers.TestAccessSpecifiers)
Ensure that C++ access specifiers are available on cursors ... /Users/runner/miniforge3/conda-bld/clang_packages_1634249809314/test_tmp/run_test.sh: line 8: 37957 Abort trap: 6           python -m unittest discover -v
Tests failed for python-clang-13.0.0-default_hccd1708_0.tar.bz2 - moving package to /Users/runner/miniforge3/conda-bld/broken

With python 3.9 it passes (see CI of last two commits).

@h-vetinari

Copy link
Copy Markdown
Member Author

Ping @isuruf, any idea why 3.10 is failing here, resp. would you be fine to merge the PR with python <3.9 for now?

@h-vetinari

Copy link
Copy Markdown
Member Author

Ping @isuruf :)

@isuruf

isuruf commented Oct 28, 2021

Copy link
Copy Markdown
Member

Can you enable artifacts on azure and revert to using 3.10 so we can debug this?

@h-vetinari

Copy link
Copy Markdown
Member Author

Can you enable artifacts on azure and revert to using 3.10 so we can debug this?

Done, failure on OSX remains. I don't have an Apple machine to test this though.

@h-vetinari

Copy link
Copy Markdown
Member Author

Ping @isuruf; artefacts are now available.

@h-vetinari

h-vetinari commented Nov 20, 2021

Copy link
Copy Markdown
Member Author

@conda-forge/clangdev

After the libffi-issues got fixed on the python-feedstock, this is now green! 🥳

The only thing that stood out to me from the logs was the following ClobberWarning that we might want to have a look at (possibly in a separate PR to unblock LLVM 13)?

ClobberWarning: This transaction has incompatible packages due to a shared path.
  packages: conda-forge/osx-64::clang_bootstrap_osx-64-12.0.1-h3b6de16_2, conda-forge/osx-64::libcxx-12.0.1-habf9029_0
  path: 'include/c++/v1/bitset'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants