-
-
Notifications
You must be signed in to change notification settings - Fork 45
clang 12.0.0 #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
clang 12.0.0 #139
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ca24adb
clang 12.0.0
xhochy 60babf3
Make clangd CompletionModel not depend on directory layout
xhochy 51c0189
Set ZLIB_ROOT on cross-compiling
xhochy 492d4b2
Add @xhochy as a maintainer
xhochy 28cbd3d
Set Python3_EXECUTABLE on Windows
xhochy af8d3e4
Fix authorship
xhochy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
recipe/patches/0001-Make-clangd-CompletionModel-not-depend-on-directory-.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| From 5b69bd706085271321e4125f616927f2176da608 Mon Sep 17 00:00:00 2001 | ||
| From: "Uwe L. Korn" <uwe.korn@quantco.com> | ||
| Date: Tue, 11 May 2021 22:12:48 +0200 | ||
| Subject: [PATCH] Make clangd CompletionModel not depend on directory layout | ||
|
|
||
| --- | ||
| clangd/quality/CompletionModel.cmake | 5 +++-- | ||
| 1 file changed, 3 insertions(+), 2 deletions(-) | ||
|
|
||
| diff --git a/clangd/quality/CompletionModel.cmake b/clangd/quality/CompletionModel.cmake | ||
| index 60c6d2a..dc0c0cd 100644 | ||
| --- a/clangd/quality/CompletionModel.cmake | ||
| +++ b/clangd/quality/CompletionModel.cmake | ||
| @@ -4,9 +4,10 @@ | ||
| # ${CMAKE_CURRENT_BINARY_DIR}. The generated header | ||
| # will define a C++ class called ${cpp_class} - which may be a | ||
| # namespace-qualified class name. | ||
| +set(CLANGD_COMPLETION_MODEL_COMPILER ${CMAKE_CURRENT_LIST_DIR}/CompletionModelCodegen.py) | ||
| function(gen_decision_forest model filename cpp_class) | ||
| - set(model_compiler ${CMAKE_SOURCE_DIR}/../clang-tools-extra/clangd/quality/CompletionModelCodegen.py) | ||
| - | ||
| + set(model_compiler ${CLANGD_COMPLETION_MODEL_COMPILER}) | ||
| + | ||
| set(output_dir ${CMAKE_CURRENT_BINARY_DIR}) | ||
| set(header_file ${output_dir}/${filename}.h) | ||
| set(cpp_file ${output_dir}/${filename}.cpp) | ||
| -- | ||
| 2.30.2 | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BUILD_PREFIX? why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed for the cross-compiled LLVM tools to detect the correct
libz. Otherwise, they also pick up the one in$PREFIX.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this is part of the very long
CROSS_TOOLCHAIN_FLAGS_NATIVEvariable value.