Skip to content

Fix import errors on osx by adding upstream patch#16

Merged
isuruf merged 3 commits into
conda-forge:masterfrom
h-vetinari:master
Jun 26, 2020
Merged

Fix import errors on osx by adding upstream patch#16
isuruf merged 3 commits into
conda-forge:masterfrom
h-vetinari:master

Conversation

@h-vetinari

Copy link
Copy Markdown
Member

Closes #15.

Follows recommendation by @isuruf.

@h-vetinari h-vetinari requested a review from isuruf as a code owner June 26, 2020 18:27
@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari

Copy link
Copy Markdown
Member Author

@conda-forge-admin, please rerender

@h-vetinari

Copy link
Copy Markdown
Member Author

@isuruf
This should be good to go.

@isuruf

isuruf commented Jun 26, 2020

Copy link
Copy Markdown
Member

Thanks

@isuruf isuruf merged commit 21e687c into conda-forge:master Jun 26, 2020
@h-vetinari

h-vetinari commented Jun 26, 2020

Copy link
Copy Markdown
Member Author

I just realised I forgot to bump the build number on this. 😬

Any follow-ups we should do? Revert this PR on master (so the previous version gets published again with build number 0), and then reissue the PR with a bumped build number?

@isuruf

isuruf commented Jun 26, 2020

Copy link
Copy Markdown
Member

6a7a881

@h-vetinari

Copy link
Copy Markdown
Member Author

Thanks. But will 21e687c not have replaced the original buildnum=0 builds already?

In any case, sorry for the extra work. 😞

@isuruf

isuruf commented Jun 26, 2020

Copy link
Copy Markdown
Member

No, there's no uploading if the same build (with same hash) exists.

@h-vetinari

Copy link
Copy Markdown
Member Author

Seems there is another (windows-specific) problem:

Using STAGING_BINSTAR_TOKEN for anaconda.org uploads to cf-staging.
No numpy version specified in conda_build_config.yaml.  Falling back to default numpy value of 1.11
Adding in variants from internal_defaults
Adding in variants from .ci_support\win_target_platformwin-64.yaml
copy results:
{
  "errors": [],
  "valid": {
    "win-64/blis-0.7.0-h62dcd97_1.tar.bz2": true
  },
  "copied": {
    "win-64/blis-0.7.0-h62dcd97_1.tar.bz2": true
  }
}
Failed to upload due to [WinError 5] Access is denied: 'C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmpavyj85kp\\binstar.token'. Trying again in 10 seconds

It already kept retrying a couple of times, but that permission error is not gonna go away, I presume...

@h-vetinari

h-vetinari commented Jun 27, 2020

Copy link
Copy Markdown
Member Author

I checked on anaconda.org, and the packages did get uploaded. However, the build-number thing caused an extra upload of 0.7.0*_0 for windows, since apparently the package hash had changed (due to the compiler bump to vs2017?). I don't think that has a huge impact, but just FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Import failure on osx with blis

3 participants