Skip to content

Fix mkl dependency#137

Merged
h-vetinari merged 2 commits into
conda-forge:mainfrom
isuruf:mkl
Feb 20, 2025
Merged

Fix mkl dependency#137
h-vetinari merged 2 commits into
conda-forge:mainfrom
isuruf:mkl

Conversation

@isuruf

@isuruf isuruf commented Feb 20, 2025

Copy link
Copy Markdown
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Fixes #136

@isuruf isuruf added the automerge Merge the PR when CI passes label Feb 20, 2025
@conda-forge-admin

conda-forge-admin commented Feb 20, 2025

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13438889379. Examine the logs at this URL for more detail.

@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@conda-forge-curator conda-forge-curator Bot removed the automerge Merge the PR when CI passes label Feb 20, 2025
@isuruf isuruf added the automerge Merge the PR when CI passes label Feb 20, 2025
@h-vetinari h-vetinari removed the automerge Merge the PR when CI passes label Feb 20, 2025

@h-vetinari h-vetinari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point of #134 was that non-MKL flavours have the <2025 constraint, so that the solver does not get tempted into switching flavours in order to maximize the MKL version.

@isuruf isuruf requested a review from h-vetinari February 20, 2025 15:33
@isuruf

isuruf commented Feb 20, 2025

Copy link
Copy Markdown
Member Author

We should merge this ASAP to make sure MKL does not get pulled in openblas flavours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

openblas and blis implementation have mkl in their dependencies

3 participants