Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
|
I assume this is part of a general conda-forge numpy update effort (the details of I do not understand and am not commenting on). Good catch on checking importing of Since you are working on this, can you also add Cross reference bioconda/bioconda-recipes#5465 for fixing the same oversight in the older BioConda recipe which this conda-forge recipe was based on. |
|
@ocefpaf there seems to be a numpy/python issue on windows with python 3.5.
Yes the idea is that we can update numpy without having to rebuild all packages depending on numpy when a new numpy version is released. |
|
@kain88-de Understood, thank you. We're trying to do something similar with the Biopython wheels for PyPI where we build against the oldest numpy as possible for each Python, so our wheels should work with any more recent numpy: https://github.com/biopython/biopython-wheels |
That is my bad. When I wrote the docs I was sure I saw I am working to get |
| - numpy x.x | ||
| - numpy 1.8.* # [not (win and (py35 or py36))] | ||
| - numpy 1.9.* # [win and py35] | ||
| - numpy 1.11.* # [win and py36] |
There was a problem hiding this comment.
@kain88-de I guess that this is the current combination. I don't really want to spread this at the moment. I'd rather work fast to get older versions of numpy in the channel so we can simplify this ASAP.
There was a problem hiding this comment.
I can wait for numpy 1.8 on windows. I rather have a correct long-term solution for the maintainers. I also changed these to see if I can break things in the build ;-)
There was a problem hiding this comment.
Cool. We'll have a meeting next Friday and I'll try to ask for a numpy 1.8 and 1.9 on defaults for both py35 and py36.
|
@kain88-de Is the patch ready for merging or should we wait until NumPy 1.8 and 1.9 is available in the default channel? |
|
@ocefpaf how are the default channels looking? @souravsingh depends on you. If we wait you don't need to change this in the future. |
Promising. We discussed that last meeting and people are looking into it. I'll know more next week. |
|
@ocefpaf any change on this? |
Nope. I'll ask again today but maybe we should not wait for that... |
|
@souravsingh You can merge this if you like. |
|
The merge is currently failing because there is an issue with the anaconda token. |
|
conda-forge/conda-forge.github.io#426 (comment) looks like we can wait until there pops up a PR to fix the issue. |
|
The short-term solution is to re-submit the recipe to staged-recipes. It won't change the recipe here, only the tokens. |
|
@ocefpaf Do I now have to submit a PR to staged-recipes with the new recipe? If so, What would happen to this feedstock repository? |
5 participants
switch to a ABI compatible numpy configuration and add python 3.4 to build matrix.