Skip to content
This repository was archived by the owner on Jan 9, 2026. It is now read-only.

Rebuild for pytorch 2.3#7

Merged
mediocretech merged 6 commits into
conda-forge:mainfrom
regro-cf-autotick-bot:rebuild-pytorch23-0-1_hcc2afc
Jun 19, 2024
Merged

Rebuild for pytorch 2.3#7
mediocretech merged 6 commits into
conda-forge:mainfrom
regro-cf-autotick-bot:rebuild-pytorch23-0-1_hcc2afc

Conversation

@regro-cf-autotick-bot

Copy link
Copy Markdown
Contributor

This PR has been triggered in an effort to update pytorch23.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/9138224294 - please use this URL for debugging.

@conda-forge-webservices

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari

Copy link
Copy Markdown
Member

@conda-forge-admin, please rerender

@h-vetinari

Copy link
Copy Markdown
Member

So this now looks okay everywhere but on python 3.8; For that, it'll be necessary to provide -I$PREFIX/include to the compiler. Normaly this is done by the compiler activation, but here upstream sets its own flags. One possible way to circumvent further patches and still fix this is to use a compiler shim (example: conda-forge/pytorch_sparse-feedstock@052af89), or to drop python 3.8

@mediocretech

Copy link
Copy Markdown
Contributor

Hi @h-vetinari, thanks for your input. I'm not seeing your optimism on the non-38 builds. Was a commit left out by chance?

@h-vetinari

Copy link
Copy Markdown
Member

There's a problem with tcolorpy metadata: conda-forge/tcolorpy-feedstock#12

We could skip the pip check here (not great), or fix things properly on the tcolorpy feedstock - would you be up for that?

@mediocretech

Copy link
Copy Markdown
Contributor

@h-vetinari thanks for all the updates! 🧙

Agreed those moves are not ideal, but I think they're what we have to work with. I've made the changes to get things building and added you as a maintainer. Happy to remove you any time you want out.

@mediocretech mediocretech merged commit 0a81f39 into conda-forge:main Jun 19, 2024
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-pytorch23-0-1_hcc2afc branch June 19, 2024 14:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants