Rebuild for CUDA 12#13
Conversation
…nda-forge-pinning 2024.07.24.06.07.47
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
37ce8f7 to
c8b02c6
Compare
this commit is easier to view without whitespace changes
…nda-forge-pinning 2024.08.08.18.59.51
jakirkham
left a comment
There was a problem hiding this comment.
Thanks Axel! 🙏
Had a couple minor suggestions below that may help this clear
| imports: | ||
| - awq |
There was a problem hiding this comment.
If this is loading libcuda.so (which requires a working GPU) and it may be doing this, we would need to skip this test
| imports: | |
| - awq | |
| imports: # [cuda_compiler_version != "None"] | |
| - awq # [cuda_compiler_version != "None"] |
Alternatively we could switch to a Quansight GPU runner
There was a problem hiding this comment.
It fails to find libtorch_python.so:
import: 'awq_ext'
Traceback (most recent call last):
File "/home/conda/feedstock_root/build_artifacts/autoawq_1723203836924/test_tmp/run_test.py", line 2, in <module>
import awq_ext
ImportError: libtorch_python.so: cannot open shared object file: No such file or directory
I don't understand how the build manages to link at buildtime, but not at runtime. Well, -Wl,--allow-shlib-undefined might explain some of it (didn't succeed in stripping this it seems), but -L$SP_DIR/torch/lib is in LDFLAGS, so I have no idea where this fails. I doubt it's the cuda drivers though.
There was a problem hiding this comment.
IIUC this was an issue in PyTorch packaging that was being worked on in PR: conda-forge/pytorch-cpu-feedstock#246
AIUI this was added to PyTorch 2.4.0: conda-forge/pytorch-cpu-feedstock#250
So likely we need to update PyTorch here too
|
Also worth noting the migrator and version updates got a bit clogged up due to a duplicate key in That is now resolved. So a bunch of bot PRs just got added to this feedstock |
upstream calculates CUDA arches from torch, does not respect TORCH_CUDA_ARCH_LIST anymore
…nda-forge-pinning 2024.08.28.19.57.49
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Given conda/conda-build#5467, I'm going to merge this for now and then see if I can layer the rest on top. |
Bot couldn't open the PR for some reason (so the restart from #2 never worked), let's try doing it manually; based on #12