-
-
Notifications
You must be signed in to change notification settings - Fork 65
Increase SIMD levels #1886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase SIMD levels #1886
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18923227704. Examine the logs at this URL for more detail. |
pitrou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 assuming CI passes
|
Fine by me as well - thanks for this!. If this passes here, I'll test this once more with the python bindings + tests on top (c.f. #1664); that gives a more complete picture IMO, and should reduce the chance of any problems slipping through unnoticed. |
|
Thanks for doing this @AntoinePrv ! |
3d2e856 to
485c3f8
Compare
|
Tests in #1664 look good! :) Thanks for this, glad to see the situation improved on this! |
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)In arrow,
SIMD_LEVEL=NONEis not a good baseline.Since
sse-4.2andneonare not included in the dynamic dispatch, the risk is to not have any acceleration at runtime for the user.The current efforts in arrow C++ is to enable more dynamic dispatch, reducing the need for making micro-arch builds variant in this feedstock.
x86-64->sse-4.2arm64->neonpowerpc-> Nonex86-64-> [avx2,avx512]arm64-> possibllysves in future releasespowerpc-> None