-
-
Notifications
You must be signed in to change notification settings - Fork 65
[main] Rebuild for libopentelemetry_cpp 1.19 #1727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Rebuild for libopentelemetry_cpp 1.19 #1727
Conversation
…nda-forge-pinning 2025.03.18.12.47.30
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13936923801. Examine the logs at this URL for more detail. |
|
@lidavidm @kou @pitrou |
|
I guess Google likes breaking changes in minor versions... |
|
I'll put a patch upstream |
Not sure what the promises there are, but given how long-lived the 1.x branch is, I'm not surprised. It's also why our otel builds are marked as "need to rebuild for every minor version" 😅
Thank you very much for the super-quick handling! 🙏 |
Oh I can be sympathetic, but it's not even called out in the changelog! It seems more like it slipped through review |
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
### Rationale for this change conda-forge/arrow-cpp-feedstock#1727 fails to build because open-telemetry/opentelemetry-cpp@762b73d is a silent breaking change. ### What changes are included in this PR? Work around the breaking change. ### Are these changes tested? I tested that it built with OTel 1.19 and 1.18. ### Are there any user-facing changes? No Lead-authored-by: David Li <[email protected]> Co-authored-by: Rossi Sun <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
This PR has been triggered in an effort to update libopentelemetry_cpp119.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/13924449011 - please use this URL for debugging.