Skip to content

Conversation

@regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update libopentelemetry_cpp119.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/13924449011 - please use this URL for debugging.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Mar 18, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13936923801. Examine the logs at this URL for more detail.

@h-vetinari
Copy link
Member

@lidavidm @kou @pitrou
Any thoughts about the following?

[141/954] Building CXX object src/arrow/CMakeFiles/arrow_util.dir/util/tracing_internal.cc.o
FAILED: src/arrow/CMakeFiles/arrow_util.dir/util/tracing_internal.cc.o 
$BUILD_PREFIX/bin/x86_64-conda-linux-gnu-c++ -DARROW_HAVE_RUNTIME_AVX2 -DARROW_HAVE_RUNTIME_AVX512 -DARROW_HAVE_RUNTIME_BMI2 -DARROW_HAVE_RUNTIME_SSE4_2 -DGFLAGS_IS_A_DLL=0 -DGLOG_USE_GFLAGS -DGLOG_USE_GLOG_EXPORT -DHAVE_ABSEIL -DOPENTELEMETRY_ABI_VERSION_NO=1 -DPROTOBUF_USE_DLLS -DURI_STATIC_BUILD -I$SRC_DIR/cpp/build/src -I$SRC_DIR/cpp/src -I$SRC_DIR/cpp/src/generated -Wno-noexcept-type -Wno-self-move -fvisibility-inlines-hidden -fmessage-length=0 -march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O2 -ffunction-sections -pipe -isystem $PREFIX/include -fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/apache-arrow-19.0.1 -fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix -fdiagnostics-color=always -fuse-ld=gold  -Wall -fno-semantic-interposition -fvisibility-inlines-hidden -fmessage-length=0 -march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O2 -ffunction-sections -pipe -isystem $PREFIX/include -fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/apache-arrow-19.0.1 -fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix -O3 -DNDEBUG -O2 -ftree-vectorize  -std=c++17 -fPIC -pthread -MD -MT src/arrow/CMakeFiles/arrow_util.dir/util/tracing_internal.cc.o -MF src/arrow/CMakeFiles/arrow_util.dir/util/tracing_internal.cc.o.d -o src/arrow/CMakeFiles/arrow_util.dir/util/tracing_internal.cc.o -c $SRC_DIR/cpp/src/arrow/util/tracing_internal.cc
In file included from $BUILD_PREFIX/lib/gcc/x86_64-conda-linux-gnu/13.3.0/include/c++/memory:78,
                 from $SRC_DIR/cpp/src/arrow/util/tracing_internal.h:20,
                 from $SRC_DIR/cpp/src/arrow/util/tracing_internal.cc:18:
$BUILD_PREFIX/lib/gcc/x86_64-conda-linux-gnu/13.3.0/include/c++/bits/unique_ptr.h: In instantiation of 'std::__detail::__unique_ptr_t<_Tp> std::make_unique(_Args&& ...) [with _Tp = arrow::internal::tracing::{anonymous}::OtlpOStreamExporter; _Args = {basic_ostream<char, char_traits<char> >*}; __detail::__unique_ptr_t<_Tp> = __detail::__unique_ptr_t<arrow::internal::tracing::{anonymous}::OtlpOStreamExporter>]':
$SRC_DIR/cpp/src/arrow/util/tracing_internal.cc:129:51:   required from here
$BUILD_PREFIX/lib/gcc/x86_64-conda-linux-gnu/13.3.0/include/c++/bits/unique_ptr.h:1070:30: error: invalid new-expression of abstract class type 'arrow::internal::tracing::{anonymous}::OtlpOStreamExporter'
 1070 |     { return unique_ptr<_Tp>(new _Tp(std::forward<_Args>(__args)...)); }
      |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
$SRC_DIR/cpp/src/arrow/util/tracing_internal.cc:69:7: note:   because the following virtual functions are pure within 'arrow::internal::tracing::{anonymous}::OtlpOStreamExporter':
   69 | class OtlpOStreamExporter final : public sdktrace::SpanExporter {
      |       ^~~~~~~~~~~~~~~~~~~
In file included from $PREFIX/include/opentelemetry/exporters/ostream/span_exporter.h:20,
                 from $SRC_DIR/cpp/src/arrow/util/tracing_internal.cc:34:
$PREFIX/include/opentelemetry/sdk/trace/exporter.h:55:16: note:     'virtual bool opentelemetry::v1::sdk::trace::SpanExporter::ForceFlush(std::chrono::microseconds)'
   55 |   virtual bool ForceFlush(
      |                ^~~~~~~~~~

@h-vetinari h-vetinari changed the title Rebuild for libopentelemetry_cpp 1.19 [main] Rebuild for libopentelemetry_cpp 1.19 Mar 18, 2025
@lidavidm
Copy link
Contributor

I guess Google likes breaking changes in minor versions...

@lidavidm
Copy link
Contributor

@lidavidm
Copy link
Contributor

I'll put a patch upstream

@lidavidm
Copy link
Contributor

apache/arrow#45859

@h-vetinari
Copy link
Member

I guess Google likes breaking changes in minor versions...

Not sure what the promises there are, but given how long-lived the 1.x branch is, I'm not surprised. It's also why our otel builds are marked as "need to rebuild for every minor version" 😅

I'll put a patch upstream

Thank you very much for the super-quick handling! 🙏

@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Mar 19, 2025
@lidavidm
Copy link
Contributor

I guess Google likes breaking changes in minor versions...

Not sure what the promises there are, but given how long-lived the 1.x branch is, I'm not surprised. It's also why our otel builds are marked as "need to rebuild for every minor version" 😅

Oh I can be sympathetic, but it's not even called out in the changelog! It seems more like it slipped through review

@conda-forge-admin conda-forge-admin merged commit c08228a into conda-forge:main Mar 19, 2025
13 checks passed
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-libopentelemetry_cpp119-0-1_heda376 branch March 19, 2025 03:56
kou pushed a commit to apache/arrow that referenced this pull request May 30, 2025
### Rationale for this change

conda-forge/arrow-cpp-feedstock#1727 fails to build because open-telemetry/opentelemetry-cpp@762b73d is a silent breaking change.

### What changes are included in this PR?

Work around the breaking change.

### Are these changes tested?

I tested that it built with OTel 1.19 and 1.18.

### Are there any user-facing changes?

No

Lead-authored-by: David Li <[email protected]>
Co-authored-by: Rossi Sun <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Merge the PR when CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants