Skip to content

Test dependencies expansion #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 5 commits into from
Sep 13, 2023
Merged

Test dependencies expansion #1174

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e802ca3
remove test skip that was due to old macos, now that we're on 10.13
h-vetinari Sep 13, 2023
81bf1d4
add minio as a test dep now that it's available
h-vetinari Sep 13, 2023
58045e8
Partially revert "don't trigger test suite too deep in file hierarchy"
h-vetinari Sep 13, 2023
87eb8cf
add boto3 & s3fs as a test deps
h-vetinari Sep 13, 2023
741ff15
skip a test on win using unsupported characters
h-vetinari Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,13 +348,16 @@ outputs:
- pytest
- pytest-lazy-fixture
- backports.zoneinfo # [py<39]
- boto3
- cffi
- cloudpickle
- cython <3
- fastparquet
- fsspec
- hypothesis
- minio-server
- pandas
- s3fs
- scipy
# these are generally (far) behind on migrating abseil/grpc/protobuf,
# and using them as test dependencies blocks the migrator unnecessarily
Expand All @@ -369,6 +372,8 @@ outputs:
source_files:
- testing/data
commands:
- cd ${SP_DIR} # [unix]
- cd %SP_DIR% # [win]
- export ARROW_TEST_DATA="${SRC_DIR}/testing/data" # [unix]
- set "ARROW_TEST_DATA=%SRC_DIR%\testing\data" # [win]

Expand All @@ -378,14 +383,14 @@ outputs:
# skip tests that raise SIGINT and crash the test suite
{% set tests_to_skip = tests_to_skip + " or (test_csv and test_cancellation)" %} # [linux]
{% set tests_to_skip = tests_to_skip + " or (test_flight and test_interrupt)" %} # [linux]
# cannot pass -D_LIBCPP_DISABLE_AVAILABILITY to test suite for our older macos sdk
{% set tests_to_skip = tests_to_skip + " or test_cpp_extension_in_python" %} # [osx]
# skip tests that make invalid(-for-conda) assumptions about the compilers setup
{% set tests_to_skip = tests_to_skip + " or test_cython_api" %} # [unix]
{% set tests_to_skip = tests_to_skip + " or test_visit_strings" %} # [unix]
# skip tests that cannot succeed in emulation
{% set tests_to_skip = tests_to_skip + " or test_debug_memory_pool_disabled" %} # [aarch64 or ppc64le]
{% set tests_to_skip = tests_to_skip + " or test_env_var_io_thread_count" %} # [aarch64 or ppc64le]
# XMinioInvalidObjectName on win: "Object name contains unsupported characters"
{% set tests_to_skip = tests_to_skip + " or test_write_to_dataset_with_partitions_s3fs" %} # [win]
# vvvvvvv TESTS THAT SHOULDN'T HAVE TO BE SKIPPED vvvvvvv
# new fsspec changed behaviour, see https://github.com/apache/arrow/issues/37555
{% set tests_to_skip = tests_to_skip + " or test_get_file_info_with_selector" %}
Expand All @@ -395,7 +400,7 @@ outputs:
{% set tests_to_skip = tests_to_skip + " or test_safe_cast_from_float_with_nans_to_int" %} # [ppc64le]
{% set tests_to_skip = tests_to_skip + " or test_float_with_null_as_integer" %} # [ppc64le]
# ^^^^^^^ TESTS THAT SHOULDN'T HAVE TO BE SKIPPED ^^^^^^^
- pytest --pyargs pyarrow -rfEs -k "not ({{ tests_to_skip }})"
- pytest pyarrow/ -rfEs -k "not ({{ tests_to_skip }})"
{% endif %}

about:
Expand Down