Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-Go Windows packages #17

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Add non-Go Windows packages #17

merged 3 commits into from
Nov 25, 2024

Conversation

lidavidm
Copy link
Contributor

@lidavidm lidavidm commented Oct 3, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@WillAyd
Copy link

WillAyd commented Oct 4, 2023

Assuming we need to be passing /WX to MSVC instead of /Werror; surprised CMake doesn't already handle this for us

@lidavidm
Copy link
Contributor Author

lidavidm commented Oct 4, 2023

So that is actually due to Go. Go is invoking cl for us and it's translating our flags like Werror into /Werror automagically. I remember running into this before and I think it's easiest to force Go to invoke mingw-gcc

I realized when I got here that I've done half of this before:
apache/arrow-adbc#634

So I think the next step here is to add a patch to GoUtils.cmake to set CC/CXX only for Go, and add mingw-gcc to the deps on windows. The issue there notes that the tests won't build/link, but that's OK for our purposes here.

@WillAyd
Copy link

WillAyd commented Oct 4, 2023

Very interesting. Definitely not a conda thing either right? I've always found the environment variables set by activation of a conda environment to be surprising...not something I looked into here just food for thought

@lidavidm
Copy link
Contributor Author

lidavidm commented Oct 4, 2023

I don't think it's Conda-specific, I think we just don't do enough testing on Windows due to my own antipathy/lack of a Windows machine

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@lidavidm
Copy link
Contributor Author

@conda-forge-admin, please rerender

@lidavidm lidavidm force-pushed the windows branch 2 times, most recently from 1709492 to c7f68b5 Compare November 14, 2024 06:00
@lidavidm lidavidm marked this pull request as ready for review November 14, 2024 06:30
@lidavidm lidavidm changed the title Windows Add non-Go Windows packages Nov 14, 2024
lidavidm added a commit to apache/arrow-adbc that referenced this pull request Nov 15, 2024
@lidavidm
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 25, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12001344868. Examine the logs at this URL for more detail.

@lidavidm lidavidm merged commit 2a38381 into conda-forge:main Nov 25, 2024
28 checks passed
@lidavidm lidavidm deleted the windows branch November 25, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants