enable cuda build#144
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
|
The CUDA builds but the MPI+cuda failed due to |
|
@conda-forge-admin, please rerender |
|
@mattwthompson This working fine when tested locally. Shall we merge this PR? |
mattwthompson
left a comment
There was a problem hiding this comment.
The green checks are good and the changes pass the eye test, but I'd like one more person to either skim the changes or test them locally.
Are there any executables that can be turned on in this file with the inclusion of CUDA?
|
@mattwthompson I think we could potentially test |
|
I think it can be tucked away under a conditional like already happens for MPI: ambertools-feedstock/recipe/run_test.sh Lines 50 to 56 in bc93c74 |
|
@conda-forge-admin, please rerender |
|
@mattwthompson Ok, I have added a |
|
@conda-forge-admin, please restart ci |
MNT: Re-rendered with conda-build 24.5.1, conda-smithy 3.36.1, and conda-forge-pinning 2024.05.29.16.17.59 Update build.sh Update meta.yaml Update meta.yaml Update conda-forge.yml MNT: Re-rendered with conda-build 24.5.1, conda-smithy 3.36.1, and conda-forge-pinning 2024.05.30.18.15.52 test cpptraj.cuda update test fix ldd
…nda-forge-pinning 2024.06.06.12.23.08
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.06.13.14.48.38
|
@conda-forge-admin, please restart ci |
|
@mattwthompson Shall we merge this before working on 24? All the builds are passing and I have test for cpptraj.cuda. |
|
It's probably fine but I'd like somebody from the Amber community to chime in |
|
@njzjz Do you mind give this PR a review? Thanks. |
|
Is there some way I could provisionally do a conda install of this? It doesn't have to be before the PR is accepted. Maybe I should just be building this myself locally(?) Are there instructions for doing that? Apologies for being so clueless -- I prepared conda (not conda-forge) packages years ago, but my grey cells are mostly gone in that (and other) areas..... |
|
You can re-configure the build process to store artifacts if they're not already there (I haven't checked), re-render, and then on the next build they're be available to download somewhere on the Azure pages that are linked in "CI" from this PR. Then you can install those as local conda packages https://conda-forge.org/docs/maintainer/conda_forge_yml/#azure Everything can be done locally (there's a |
|
@dacase Building the linux version is quite easy, you just find a linux machine. clone the repo, run |
|
@xiki-tempula could you merge the After that I'll merge tomorrow morning if nobody else got to it by then (or objects) |
| numpy: | ||
| - '1.22' | ||
| openmpi: | ||
| - '5' |
There was a problem hiding this comment.
@mattwthompson I have already merged the main to this branch and rerendered the branch. You could see that openmpi is version 5 and zlib is 1
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)