Rebuild for pytorch 2.5#20
Conversation
…nda-forge-pinning 2024.11.05.21.36.17
regro-cf-autotick-bot
requested review from
PabloCarmona,
kaoutar55 and
kkvtran
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12943976494. Examine the logs at this URL for more detail. |
|
@conda-forge-admin please rerender |
|
|
||
| package: | ||
| name: {{ pname|lower }} | ||
| name: aihwkit |
There was a problem hiding this comment.
Unlike pypi packages, we have the ability to have different variants of our packages with hardware capabilities.
To avoid users having to create different environment.yml files for cuda/cpu, we tend to keep the name of the hardware accelerated packages the same.
I only created the pytorch-cpu and pytorch-gpu since at the time, I was following the upstream pytorch package names.
To keep things "similar" for your users, i've created the aihwkit-cpu and aihwkit-gpu packages in addition to your naked name aihwkit.
Recipe can now depend on aihwkit unconditionally.
…nda-forge-pinning 2024.11.23.20.32.37
| {% set name = "aihwkit" %} | ||
| {% set version = "0.9.2" %} | ||
| {% set number = 0 %} | ||
| {% set build = 1 %} |
There was a problem hiding this comment.
Using {{ number }} messes with the bot's ability to bump it on PRs.
You should use {{ build }}
| - cuda-version {{ cuda_compiler_version }} # [cuda_compiler_version != "None"] | ||
| - libcublas-dev # [(cuda_compiler_version or "").startswith("12")] | ||
| - libcurand-dev # [(cuda_compiler_version or "").startswith("12")] | ||
| - mkl-devel |
There was a problem hiding this comment.
mkl-devel should include mkl and mkl-include (as well as blas I believe) and provide you with the correct run exports.
|
@conda-forge-admin please rerender |
…nda-forge-pinning 2024.11.23.20.32.37
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2025.01.23.20.59.37
|
AFAICT, this package still uses an old pip argument that got removed |
5 participants
This PR has been triggered in an effort to update pytorch25.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/11695311053 - please use this URL for debugging.