Skip to content

remove bad pinned proj cartopy#145

Merged
isuruf merged 1 commit intoconda-forge:masterfrom
ocefpaf:remove_bad_cartopy
Oct 18, 2020
Merged

remove bad pinned proj cartopy#145
isuruf merged 1 commit intoconda-forge:masterfrom
ocefpaf:remove_bad_cartopy

Conversation

@ocefpaf
Copy link
Copy Markdown
Member

@ocefpaf ocefpaf commented Oct 18, 2020

@xylar do you mind taking a quick look? If I'm correct the affected ones are build numbers 0 and 1 for 0.18 only.

@ocefpaf ocefpaf requested a review from a team as a code owner October 18, 2020 14:52
@isuruf
Copy link
Copy Markdown
Member

isuruf commented Oct 18, 2020

cc @conda-forge/cartopy

I think I'm missing the context here. Any issue or PR that I can look at?

@xylar
Copy link
Copy Markdown
Contributor

xylar commented Oct 18, 2020

These builds did not constrain proj, and as a result we're getting installs that can use an older, incompatible proj. Upstream didn't specify that proj is a dependency (thus, I removed it as a dependency), but @ocefpaf noticed that this was causing trouble and re-introduced it in build 2. The same may also be true of geos.

Here are the 2 PRs for the bad builds:
conda-forge/cartopy-feedstock#88
conda-forge/cartopy-feedstock#89
Note that proj gets removed in conda-forge/cartopy-feedstock#88 and re-added in conda-forge/cartopy-feedstock#91

Here is an issue where we discuss the issue:
conda-forge/cartopy-feedstock#93

@xylar
Copy link
Copy Markdown
Contributor

xylar commented Oct 18, 2020

@xylar do you mind taking a quick look? If I'm correct the affected ones are build numbers 0 and 1 for 0.18 only.

@ocefpaf, that's correct. If geos is also a problem, though, all builds of 0.18 will be affected and only by new PR will fix that: conda-forge/cartopy-feedstock#94, which would mean builds 2 and 3 are also broken.

@isuruf isuruf merged commit d2cd35b into conda-forge:master Oct 18, 2020
@xylar
Copy link
Copy Markdown
Contributor

xylar commented Oct 19, 2020

@isuruf and @ocefpaf, I'm seeing these packages labeled as broken but still in main:
https://anaconda.org/conda-forge/cartopy/files
Is this expected?

I am still able to install build 0:

conda create -y -n test python=3.8 cartopy=0.18.0 proj=6.3.1

...

  cartopy            conda-forge/linux-64::cartopy-0.18.0-py38h172510d_0

It could be that everything is fine and I have a local cache that I can't delete because it's already being used in another env.

@xhochy
Copy link
Copy Markdown
Member

xhochy commented Oct 19, 2020

Yes, that is expected. We remove the main label on the CDN via repodata patching. If you look at the plain repodata.json returned by the CDN Url, the package shouldn't be listed anymore.

@xylar
Copy link
Copy Markdown
Contributor

xylar commented Oct 19, 2020

Thanks @xhochy.

@ocefpaf
Copy link
Copy Markdown
Member Author

ocefpaf commented Oct 19, 2020

Thanks @xylar for taking care of this.
Sorry @isuruf, I sent the PR and did not add the proper context.
Also thanks @xhochy for the main explanation.

@xylar I'll look into the geos issue today. It is probably broken too but maybe we are in the "clear" b/c other deps, like shapely, are bringing the right one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants