fix(cvm): patch vLLM Harmony streaming tool-call fallback#78
Merged
Conversation
youben11
requested changes
Feb 27, 2026
Collaborator
youben11
left a comment
There was a problem hiding this comment.
We need to have a workflow to build (potentially test) the image, push it to ghcr, and also add provenance since we are doing the build of vllm now
Contributor
Author
yes I will add. But eventually we will use vllm once the proper fix is in vllm |
Collaborator
|
If it lands and the image is just temporary, then okay. Let's see depending on the PR state |
f46fc6c to
e9d6475
Compare
67fd0b6 to
abb1e82
Compare
abb1e82 to
34d1740
Compare
youben11
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cvm/vllm-patch/with a Dockerfile overlay that applies the fix at image build timeghcr.io/concrete-security/vllm-openai:v0.13.0-harmony-fixdocker-compose.ymlto use the patched imageDetails
Harmony mode can finish streaming without emitting tool-call deltas even when the full token stream contains a valid function call. The fix adds a fallback that re-parses accumulated harmony tokens once at finish time to recover missed tool calls.
Test plan
cd cvm/vllm-patch && docker build .