Skip to content

fix(cvm): patch vLLM Harmony streaming tool-call fallback#78

Merged
jfrery merged 3 commits intomainfrom
add-fixed-oss-agent-vllm
Feb 27, 2026
Merged

fix(cvm): patch vLLM Harmony streaming tool-call fallback#78
jfrery merged 3 commits intomainfrom
add-fixed-oss-agent-vllm

Conversation

@jfrery
Copy link
Copy Markdown
Contributor

@jfrery jfrery commented Feb 26, 2026

Summary

  • Patches vLLM v0.13.0 to fix Harmony streaming mode occasionally missing tool-call deltas at finish time
  • Adds cvm/vllm-patch/ with a Dockerfile overlay that applies the fix at image build time
  • Publishes patched image as ghcr.io/concrete-security/vllm-openai:v0.13.0-harmony-fix
  • Updates docker-compose.yml to use the patched image

Details

Harmony mode can finish streaming without emitting tool-call deltas even when the full token stream contains a valid function call. The fix adds a fallback that re-parses accumulated harmony tokens once at finish time to recover missed tool calls.

Test plan

  • Deploy CVM with updated docker-compose and verify tool calls work in streaming mode
  • Verify the patched image builds cleanly: cd cvm/vllm-patch && docker build .

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 26, 2026

@jfrery jfrery requested review from kcelia and youben11 February 26, 2026 15:19
Copy link
Copy Markdown
Collaborator

@youben11 youben11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to have a workflow to build (potentially test) the image, push it to ghcr, and also add provenance since we are doing the build of vllm now

@jfrery
Copy link
Copy Markdown
Contributor Author

jfrery commented Feb 27, 2026

We need to have a workflow to build (potentially test) the image, push it to ghcr, and also add provenance since we are doing the build of vllm now

yes I will add. But eventually we will use vllm once the proper fix is in vllm

ref vllm-project/vllm#35449

@youben11
Copy link
Copy Markdown
Collaborator

If it lands and the image is just temporary, then okay. Let's see depending on the PR state

@jfrery jfrery requested a review from youben11 February 27, 2026 07:50
@jfrery jfrery force-pushed the add-fixed-oss-agent-vllm branch from f46fc6c to e9d6475 Compare February 27, 2026 08:03
@jfrery jfrery force-pushed the add-fixed-oss-agent-vllm branch from 67fd0b6 to abb1e82 Compare February 27, 2026 08:06
@jfrery jfrery force-pushed the add-fixed-oss-agent-vllm branch from abb1e82 to 34d1740 Compare February 27, 2026 08:27
@jfrery jfrery merged commit f9620eb into main Feb 27, 2026
4 checks passed
@jfrery jfrery deleted the add-fixed-oss-agent-vllm branch February 27, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants