-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I should see a footer on all pages with the specified styling and links #155
Comments
for the underline, mdgriffith/elm-ui#158, won't be as easy as we'd hope override time |
actually i might be able to do it with a very sharp shadow... edit: naw that'll be harder |
for the actual terms of use page, some sort of routing needs to be set up... good reference: |
previous tests which test the model changes are broken cause no testing for Browser / Nav.Key (which we use for changing the url) time to ponder this |
- added css overrides file for things that can't be done in elm-ui #155 Signed-off-by: James Thomson <[email protected]>
The underline isn't necessary if there's no easy implementation. There are a number of other options (bold the text, darken the color of the text, or just keep as is with a changing tooltip on hover which should be built into the browser by default) |
@ibagha footer stuff should be up on the test site! |
- added css overrides file for things that can't be done in elm-ui #155 Signed-off-by: James Thomson <[email protected]>
- added css overrides file for things that can't be done in elm-ui #155 Signed-off-by: James Thomson <[email protected]>
- added actual retrieval of data for cards - added footer - loading assets differently (see index.html) #60 #99 #102 #155 Signed-off-by: James Thomson <[email protected]>
A/C
Link to Figma: https://www.figma.com/file/pmLRwbPKrwDAGn6XLDoUiA/Concourse-Resources?node-id=1182%3A60
The text was updated successfully, but these errors were encountered: