Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I should see a footer on all pages with the specified styling and links #155

Closed
4 of 5 tasks
ibagha opened this issue Dec 17, 2019 · 6 comments
Closed
4 of 5 tasks

Comments

@ibagha
Copy link

ibagha commented Dec 17, 2019

A/C

  • When I hover over the links, they should be underlined
  • When I click 'Terms of Use', I should be taken to the terms of use page
  • When I click 'Contribute' I should be taken to the Contribution readme
  • When I click feedback, I should be taken to the github issues pages where I can submit feedback (https://github.com/concourse/dutyfree/issues/new)
  • Styling should match mocks in Figma

Link to Figma: https://www.figma.com/file/pmLRwbPKrwDAGn6XLDoUiA/Concourse-Resources?node-id=1182%3A60

@ibagha ibagha added this to the Marketplace 1.0 milestone Dec 17, 2019
@jomsie
Copy link
Contributor

jomsie commented Dec 19, 2019

for the underline, mdgriffith/elm-ui#158, won't be as easy as we'd hope

override time

@jomsie
Copy link
Contributor

jomsie commented Dec 19, 2019

actually i might be able to do it with a very sharp shadow...

edit: naw that'll be harder

@jomsie
Copy link
Contributor

jomsie commented Dec 20, 2019

for the actual terms of use page, some sort of routing needs to be set up... good reference:

https://elm.christmas/2018/15

@jomsie
Copy link
Contributor

jomsie commented Dec 20, 2019

elm-explorations/test#24
:(

previous tests which test the model changes are broken cause no testing for Browser / Nav.Key (which we use for changing the url)

time to ponder this

jomsie pushed a commit that referenced this issue Dec 20, 2019
- added css overrides file for things that can't be done in elm-ui

#155

Signed-off-by: James Thomson <[email protected]>
@ibagha
Copy link
Author

ibagha commented Dec 21, 2019

for the underline, mdgriffith/elm-ui#158, won't be as easy as we'd hope

override time

The underline isn't necessary if there's no easy implementation. There are a number of other options (bold the text, darken the color of the text, or just keep as is with a changing tooltip on hover which should be built into the browser by default)

@jomsie
Copy link
Contributor

jomsie commented Jan 9, 2020

@ibagha footer stuff should be up on the test site!

YoussB pushed a commit that referenced this issue Jan 10, 2020
- added css overrides file for things that can't be done in elm-ui

#155

Signed-off-by: James Thomson <[email protected]>
YoussB pushed a commit that referenced this issue Jan 10, 2020
- added css overrides file for things that can't be done in elm-ui

#155

Signed-off-by: James Thomson <[email protected]>
jomsie pushed a commit that referenced this issue Jan 10, 2020
- added actual retrieval of data for cards
- added footer
- loading assets differently (see index.html)

#60
#99
#102
#155

Signed-off-by: James Thomson <[email protected]>
@YoussB YoussB closed this as completed Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants