Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String diffs don't invert properly #40

Closed
novemberborn opened this issue Oct 23, 2017 · 2 comments · Fixed by #69
Closed

String diffs don't invert properly #40

novemberborn opened this issue Oct 23, 2017 · 2 comments · Fixed by #69
Labels
bug 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt

Comments

@novemberborn
Copy link
Member

novemberborn commented Oct 23, 2017

Issuehunt badges

In AVA, when diffing snapshots the gutters are inverted. This doesn't invert the string diff colors though. Compare the output for these tests:

import test from 'ava'

test('snapshot diff', t => {
  t.snapshot(`\n${Date.now()}\n`, 'the - value should be less than the + value')
})

test('direct diff', t => {
  t.is(`\n${Date.now() - 42e5}\n`, `\n${Date.now()}\n`)
})

screen shot 2017-10-23 at 15 48 57

I realized this previously but hadn't yet filed the issue. Example via avajs/ava#1558.


IssueHunt Summary

ninevra ninevra has been rewarded.

Backers (Total: $40.00)

Submitted pull Requests


Tips

@IssueHuntBot
Copy link

@IssueHunt has funded $40.00 to this issue.


novemberborn pushed a commit that referenced this issue Mar 2, 2021
Allows formatting strings nested inside items, mapEntries, and
properties.

Fixes #40.
@issuehunt-oss
Copy link

issuehunt-oss bot commented Mar 2, 2021

@novemberborn has rewarded $36.00 to @ninevra. See it on IssueHunt

  • 💰 Total deposit: $40.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $4.00

@issuehunt-oss issuehunt-oss bot added the 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt label Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants