Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CC] Improve IME support #1

Merged
merged 3 commits into from
Jul 8, 2020
Merged

[CC] Improve IME support #1

merged 3 commits into from
Jul 8, 2020

Conversation

kswenson
Copy link
Member

@kswenson kswenson commented Jul 8, 2020

Is this adding or improving a feature or fixing a bug?

Fixing IME bugs

What's the new behavior?

  1. Caret stays at correct location during IME input.
  2. insertFromComposition event handled properly.

How does this change work?

Cobbles together proposed fixes from the following issues/pull requests/comments:

Have you checked that...?

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)

Does this fix any issues or need any specific reviewers?

Fixes: #
Reviewers: @

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant