Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: update webpack and other dependencies #67

Merged
merged 6 commits into from
Jul 6, 2023
Merged

Conversation

pjanik
Copy link
Member

@pjanik pjanik commented Jul 6, 2023

https://www.pivotaltracker.com/story/show/185545046

This was necessary, so we can deploy and release this project again (Google Analytics update).
It's not perfect, as now there are some warnings about THREE.js and OrbitControls (that's why I had to disable dev server overlay), but there's no time to make a proper update and migrate THREE.js ~50 versions (from v102 to v154).

@kswenson, sorry for the random review request, but I think there's no one left in the orange team now 😉

@pjanik pjanik requested a review from kswenson July 6, 2023 14:25
Copy link
Member

@kswenson kswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM -- a PT story to clean up the remaining issues at some point (e.g. --legacy-peer-deps) might be a good idea so they don't get forgotten.

@pjanik pjanik merged commit 1f10426 into master Jul 6, 2023
@pjanik pjanik deleted the new-webpack branch July 6, 2023 22:14
@pjanik
Copy link
Member Author

pjanik commented Jul 7, 2023

Frankly speaking, I don't think there'll be time or will to do that, as I don't think there are any new features coming. This was just about updating Google Analytics tag. But if there's any round of development, then yes, we definitely need a few days of typical maintenance.

Re --legacy-peer-deps - I think we should get used to that flag. This is exactly what was happening in old Node/NPM versions, and I think it's still better to move to more recent versions and use legacy mode than keep using old Node and pretend there's no problem, as there's no warning (this version conflict is still there, just not announced 😉).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants