Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed legacy apple tools (but new ones need to be modernized yet) #10277

Merged
merged 17 commits into from
Jan 26, 2022

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Jan 5, 2022

Basically, replacing the legacy tools.apple... with conan.tools.apple and some other minor changes:

  • Tools not made public yet, the UIs need to be revised against real-life use cases and ConanCenter.
  • Now, XCRun is going to be used only for testing purposes.
  • Removing the sdk=None value for all the Apple OSs from settings.yml. For instance:
      Macos:
             version: [None, "10.6", "10.7", "10.8", "10.9", "10.10", "10.11", "10.12", "10.13", "10.14", "10.15", "11.0", "12.0", "13.0"]
         iOS:
             sdk: ["iphoneos", "iphonesimulator"]
     . . .
    

Now it must be explicitly written in the user profiles via os.sdk (except for Macos because it's automatically put as macosx).

  • Simplified and refactored functions like apple_min_version_flag().

@memsharded memsharded marked this pull request as ready for review January 25, 2022 13:29
Copy link
Member Author

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lasote lasote merged commit be66c49 into conan-io:develop2 Jan 26, 2022
@memsharded memsharded deleted the remove/develop2_tools_apple branch January 26, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants