-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed legacy apple tools (but new ones need to be modernized yet) #10277
Merged
lasote
merged 17 commits into
conan-io:develop2
from
memsharded:remove/develop2_tools_apple
Jan 26, 2022
Merged
removed legacy apple tools (but new ones need to be modernized yet) #10277
lasote
merged 17 commits into
conan-io:develop2
from
memsharded:remove/develop2_tools_apple
Jan 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
commented
Jan 25, 2022
memsharded
commented
Jan 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
lasote
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, replacing the legacy
tools.apple...
withconan.tools.apple
and some other minor changes:sdk=None
value for all the Apple OSs fromsettings.yml
. For instance:Now it must be explicitly written in the user profiles via
os.sdk
(except forMacos
because it's automatically put asmacosx
).apple_min_version_flag()
.