Skip to content

rocksdb: modernize#9362

Merged
conan-center-bot merged 3 commits into
conan-io:masterfrom
SpaceIm:rocksdb-modernize
Mar 3, 2022
Merged

rocksdb: modernize#9362
conan-center-bot merged 3 commits into
conan-io:masterfrom
SpaceIm:rocksdb-modernize

Conversation

@SpaceIm
Copy link
Copy Markdown
Contributor

@SpaceIm SpaceIm commented Feb 12, 2022


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

also depends on onetbb recipe instead of tbb (deprecated)
@conan-center-bot
Copy link
Copy Markdown
Contributor

All green in build 1 (c13e66e5eb019f91006cb68fb8d8e3812f073cb9):

  • rocksdb/6.8.1@:
    All packages built successfully! (All logs)

  • rocksdb/6.20.3@:
    All packages built successfully! (All logs)

  • rocksdb/6.0.2@:
    All packages built successfully! (All logs)

  • rocksdb/6.10.2@:
    All packages built successfully! (All logs)

Copy link
Copy Markdown
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SpaceIm
Copy link
Copy Markdown
Contributor Author

SpaceIm commented Feb 21, 2022

It would be better to merge #9164 before this one.

@SSE4
Copy link
Copy Markdown
Contributor

SSE4 commented Feb 21, 2022

It would be better to merge #9164 before this one.

sounds reasonable. I am blocking it for a while.

@SSE4 SSE4 added the blocked Affected by an external issue and waiting until it is solved label Feb 21, 2022
@SpaceIm
Copy link
Copy Markdown
Contributor Author

SpaceIm commented Feb 26, 2022

@SSE4 no need to block this PR anymore. #9164 has been merged.

@SSE4 SSE4 removed the blocked Affected by an external issue and waiting until it is solved label Feb 27, 2022
@conan-center-bot conan-center-bot merged commit a00de66 into conan-io:master Mar 3, 2022
@SpaceIm SpaceIm deleted the rocksdb-modernize branch March 3, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants