Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fmt/7.1.3: Install fmt/args.h #5800

Closed
wants to merge 1 commit into from
Closed

fmt/7.1.3: Install fmt/args.h #5800

wants to merge 1 commit into from

Conversation

alejandro-colomar
Copy link
Contributor

@alejandro-colomar alejandro-colomar commented Jun 7, 2021 •
edited
Loading

fmt/7.1.3

Apply upstream unreleased patch

cppserver/1.0.1.0 depends on fmt's master branch, which has
applied this patch. Without it, cppserver/1.0.1.0 won't build,
apparently.

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@alejandro-colomar
fmt/7.1.3: Apply upstream unreleased patch
542c84d 
cppserver/1.0.1.0 depends on fmt's master branch, which has
applied this patch.  Without it, cppserver/1.0.1.0 won't build,
apparently.

Signed-off-by: Alejandro Colomar (EXFO) <[email protected]>
@alejandro-colomar alejandro-colomar changed the title fmt/7.1.3: Apply upstream unreleased patch fmt/7.1.3: Install fmt/args.h Jun 7, 2021
@prince-chrismc
Copy link
Contributor

I am not sure this is correct.... the file is supposed to be absent in 7.1.3

fmtlib/fmt#2096

the problem is cppcommon does not use the released versions #5786 (comment)

@prince-chrismc
Copy link
Contributor

Apply upstream unreleased patch

#3951 It's build system but It's already fixed, FMT releases are often I think it's better to wait for a next release

@ghost ghost mentioned this pull request Jun 7, 2021
Closed
@ghost
Copy link

ghost commented Jun 7, 2021

I detected other pull requests that are modifying fmt/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request Jun 7, 2021
Merged
4 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
@prince-chrismc
Copy link
Contributor

You'll need to retrigger CI, close the pr wait 10s and then re-open it 🔁

This was referenced Jun 7, 2021
Open
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@alejandro-colomar
Copy link
Contributor Author

Why is it failing at random versions?

@prince-chrismc
Copy link
Contributor

CI backend unstability.... Record number of PR's trying to be merged

MSBUILD : error MSB4166: Child node "2" exited prematurely. Shutting down.

You'll need to retrigger again (few more maybe)

@alejandro-colomar
Copy link
Contributor Author

Apply upstream unreleased patch

#3951 It's build system but It's already fixed, FMT releases are often I think it's better to wait for a next release

I commented this to my boss. We can't wait, so if you don't mind, I'd prefer to patch it already :)

@conan-center-bot
Copy link
Collaborator

Failure in build 3 (542c84dea01937c6ce3f5d3a2c81936028a580ec):

  • fmt/5.3.0@:
    All packages built successfully! (All logs)

  • fmt/6.1.0@:
    All packages built successfully! (All logs)

  • fmt/6.0.0@:
    All packages built successfully! (All logs)

  • fmt/6.1.1@:
    All packages built successfully! (All logs)

  • fmt/6.1.2@:
    All packages built successfully! (All logs)

  • fmt/7.0.1@:
    All packages built successfully! (All logs)

  • fmt/7.1.0@:
    All packages built successfully! (All logs)

  • fmt/7.0.2@:
    All packages built successfully! (All logs)

  • fmt/6.2.0@:
    All packages built successfully! (All logs)

  • fmt/6.2.1@:
    All packages built successfully! (All logs)

  • fmt/7.1.3@:
    CI failed to create some packages (All logs)

    Logs for packageID d0ec62fc032e5a10524fa454546aa1bdbb22baf8: 
    [settings]
arch=x86_64
arch_build=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=6
os=Linux
os_build=Linux
[options]
fmt:shared=False

    [...]
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Conan: called by CMake conan helper
-- Conan: called inside local cache
-- Conan: Adjusting output directories
-- Conan: Using cmake global configuration
-- Conan: Adjusting default RPATHs Conan policies
-- Conan: Adjusting language standard
-- Conan: Adjusting fPIC flag (ON)
-- Conan: Compiler GCC>=5, checking major version 6
-- Conan: Checking correct version: 6
-- Conan: C++ stdlib: libstdc++11
-- Version: 7.1.3
-- Build type: Release
-- CXX_STANDARD: 11
-- Performing Test has_std_11_flag
-- Performing Test has_std_11_flag - Success
-- Performing Test has_std_0x_flag
-- Performing Test has_std_0x_flag - Success
-- Performing Test SUPPORTS_USER_DEFINED_LITERALS
-- Performing Test SUPPORTS_USER_DEFINED_LITERALS - Success
-- Performing Test FMT_HAS_VARIANT
-- Performing Test FMT_HAS_VARIANT - Failed
-- Required features: cxx_variadic_templates
-- Looking for strtod_l
-- Looking for strtod_l - not found
-- Configuring done
fmt/7.1.3: 
CMake Error at source_subfolder/CMakeLists.txt:195 (add_library):
  Cannot find source file:

    include/fmt/args.h

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .m .M .mm .h .hh .h++ .hm
  .hpp .hxx .in .txx


CMake Error at source_subfolder/CMakeLists.txt:195 (add_library):
  No SOURCES given to target: fmt


CMake Generate step failed.  Build files cannot be regenerated correctly.
fmt/7.1.3: WARN: Build folder is dirty, removing it: /home/conan/w/BuildSingleReference/.conan/data/fmt/7.1.3/_/_/build/d0ec62fc032e5a10524fa454546aa1bdbb22baf8
fmt/7.1.3: ERROR: Package 'd0ec62fc032e5a10524fa454546aa1bdbb22baf8' build failed
fmt/7.1.3: WARN: Build folder /home/conan/w/BuildSingleReference/.conan/data/fmt/7.1.3/_/_/build/d0ec62fc032e5a10524fa454546aa1bdbb22baf8
ERROR: fmt/7.1.3: Error in build() method, line 63
	cmake = self._configure_cmake()
while calling '_configure_cmake', line 56
	self._cmake.configure(build_folder=self._build_subfolder)
	ConanException: Error 1 while executing cd '/home/conan/w/BuildSingleReference/.conan/data/fmt/7.1.3/_/_/build/d0ec62fc032e5a10524fa454546aa1bdbb22baf8/build_subfolder' && cmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE="Release" -DCONAN_IN_LOCAL_CACHE="ON" -DCONAN_COMPILER="gcc" -DCONAN_COMPILER_VERSION="6" -DCONAN_CXX_FLAGS="-m64" -DCONAN_SHARED_LINKER_FLAGS="-m64" -DCONAN_C_FLAGS="-m64" -DCONAN_LIBCXX="libstdc++11" -DBUILD_SHARED_LIBS="OFF" -DCMAKE_INSTALL_PREFIX="/home/conan/w/BuildSingleReference/.conan/data/fmt/7.1.3/_/_/package/d0ec62fc032e5a10524fa454546aa1bdbb22baf8" -DCMAKE_INSTALL_BINDIR="bin" -DCMAKE_INSTALL_SBINDIR="bin" -DCMAKE_INSTALL_LIBEXECDIR="bin" -DCMAKE_INSTALL_LIBDIR="lib" -DCMAKE_INSTALL_INCLUDEDIR="include" -DCMAKE_INSTALL_OLDINCLUDEDIR="include" -DCMAKE_INSTALL_DATAROOTDIR="share" -DCONAN_CMAKE_POSITION_INDEPENDENT_CODE="ON" -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY="ON" -DCONAN_EXPORTED="1" -DFMT_DOC="False" -DFMT_TEST="False" -DFMT_INSTALL="True" -DFMT_LIB_DIR="lib" -Wno-dev '/home/conan/w/BuildSingleReference/.conan/data/fmt/7.1.3/_/_/build/d0ec62fc032e5a10524fa454546aa1bdbb22baf8'

  • fmt/7.0.3@:
    An unexpected error happened and has been reported

  • fmt/7.1.1@:
    Didn't run or was cancelled before finishing

  • fmt/7.1.2@:
    Didn't run or was cancelled before finishing

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@alejandro-colomar
Copy link
Contributor Author

alejandro-colomar commented Jun 8, 2021 •
edited
Loading

Finally, I installed conan through pip in my other laptop. Now the hooks are working for me. (however, I'd still appreciate to be able to install with the Debian package manager).

Now I tested this locally, and I realized that fmt/7.1.3 didn't have that file, so you're right that it doesn't apply ;)

So, let's wait for fmt/7.2.0.

@prince-chrismc
Copy link
Contributor

I asked for a release fmtlib/fmt#2096 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Failed Unexpected Error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alejandro-colomar @prince-chrismc @conan-center-bot