opentelemetry-cpp: add with_otlp_grpc_credentials_preview option#29058
Open
snakethatlovesstaticlibs wants to merge 6 commits into
Open
opentelemetry-cpp: add with_otlp_grpc_credentials_preview option#29058snakethatlovesstaticlibs wants to merge 6 commits into
with_otlp_grpc_credentials_preview option#29058snakethatlovesstaticlibs wants to merge 6 commits into
Conversation
|
|
snakethatlovesstaticlibs
changed the title
with_otlp_grpc_credentials optionwith_otlp_grpc_credentials_preview option
Author
|
Hmm we might also need to append a define somewhere like self.cpp_info.components["api"].defines.append(f"OPENTELEMETRY_ABI_VERSION_NO={2 if self.options.with_abi_v2 else 1}") |
…-grpc-credentials
…-grpc-credentials
Author
|
@AbrilRBS thanks for assigning the PR to yourself. Can you please take a look and provide feedback on the approach when you have a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: opentelemetry-cpp/1.22.0
Motivation
In open-telemetry/opentelemetry-cpp#3403, a method to pass custom credentials handlers was added to
opentelemetry-cpp. However, it is flagged so it is difficult to use without conan support for the flagDetails
This PR adds
with_otlp_grpc_credentials_previewwhich is passed through asWITH_OTLP_GRPC_CREDENTIAL_PREVIEWto opentelemetry-cppAdd a 👍 reaction to pull requests you find important to help the team prioritize, thanks!