-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mikktspace 20200325 #2899
Add mikktspace 20200325 #2899
Conversation
Some configurations of 'mikktspace/cci.20200325' failed in build 1 (
|
Some configurations of 'mikktspace/cci.20200325' failed in build 2 (
|
All green in build 3 (
|
def _extracted_license(self): | ||
content_lines = open(os.path.join(self.source_folder, self._source_subfolder, "mikktspace.h")).readlines() | ||
license_content = [] | ||
for i in range(4, 21): | ||
license_content.append(content_lines[i][4:-1]) | ||
return "\n".join(license_content) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if the file changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an unmaintained project. I don't think this will change in the future.
Co-authored-by: Michael "Croydon" Keck <[email protected]>
An unexpected error happened and has been reported. Help is on its way! 🏇 |
All green in build 5 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost good to go.
Co-authored-by: Uilian Ries <[email protected]>
bde27f1
All green in build 6 (
|
This has been merged because of 3 positive reviews: 2 from the team and 1 from the community Congratulations! This is the first PR merged taking into account 1 approved review from the community 🎉 Still testing and supervising, the plan is to require 1 from the team and 2 from the community as said in the blogpost, this is an intermediate step while we check it is working as expected. |
Specify library name and version: mikktspace/cci.20200325
conan-center hook activated.