Skip to content

Conversation

@akos-fulop-public
Copy link
Contributor

@akos-fulop-public akos-fulop-public commented Sep 21, 2025

Summary

Changes to recipe: llama-cpp/b6565

Motivation

Request: #28433

Details

Patch no longer seems necessary, as of ggml-org/llama.cpp#14613


@franramirez688
Copy link
Contributor

Hi @akos-fulop-public, thanks for contributing!

You need to add the new version b6529 to the config.yml too:

--- a/recipes/llama-cpp/config.yml
+++ b/recipes/llama-cpp/config.yml
@@ -1,4 +1,6 @@
 versions:
+  "b6529":
+    folder: "all"
   "b4570":
     folder: "all"
   "b4079":

@franramirez688 franramirez688 self-assigned this Sep 23, 2025
@akos-fulop-public
Copy link
Contributor Author

Hi @franramirez688 ,
Thanks, sorry I missed that!

@akos-fulop-public
Copy link
Contributor Author

Previous build failed on macOS.
As far as I could tell, this property (https://developer.apple.com/documentation/metal/mtlbuffer/gpuaddress) is only added in macOS 13, and the CI runs on lower version.
I looked at the prebuild_tool_package template, but I'm uncertain if the check I added here is a good solution.

@uilianries
Copy link
Member

uilianries commented Sep 24, 2025

The Windows build failed with (https://github.com/conan-io/conan-center-index/pull/28435/checks?check_run_id=51103353004):

C:\workspace\cci_prod_PR-28435\conan-home\p\b\llama49bf62bb2ee1b\b\src\common\common.cpp(432): error C2039: 'system_clock': is not a member of 'std::chrono'

I opened a PR to the upstream with a quick fix: ggml-org/llama.cpp#16211

@akos-fulop-public
Copy link
Contributor Author

Thank you @uilianries ,
I updated to the version that includes the fix.

@akos-fulop-public akos-fulop-public changed the title llama-cpp: Bump to version b6529 (#28433) llama-cpp: Bump to version b6565 (#28433) Sep 24, 2025
@czoido czoido requested review from uilianries and removed request for czoido September 24, 2025 08:03
@uilianries
Copy link
Member

That new release fixed that error in common.cpp, but the old version is failing due missing chrono header in log.cpp. It's fixed already in newer versions.

I would suggest reverting conanfile.py to keep it as in Conan Center, so the CI will build only the version b6565 and should not fail with that error.

@akos-fulop-public
Copy link
Contributor Author

Thanks for the help @uilianries !
Am I supposed to clean up my commits / is there anything else I need to do now?

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@czoido czoido merged commit e8b72c4 into conan-io:master Sep 25, 2025
8 checks passed
hoyhoy pushed a commit to hoyhoy/conan-center-index that referenced this pull request Oct 10, 2025
* llama-cpp: Bump to version b6529 (conan-io#28433)

* add new llama-cpp version to config

* require macOS 13 and up

* llama-cpp: Bump to version b6565 (conan-io#28433)

* rever conanfile changes
jeremydumais pushed a commit to jeremydumais/conan-center-index that referenced this pull request Oct 11, 2025
* llama-cpp: Bump to version b6529 (conan-io#28433)

* add new llama-cpp version to config

* require macOS 13 and up

* llama-cpp: Bump to version b6565 (conan-io#28433)

* rever conanfile changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants