Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdl_ttf: add v2.24.0 #26355

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Conversation

kambala-decapitator
Copy link
Contributor

Summary

Changes to recipe: sdl_ttf/2.24.0

Motivation

new library version

Details


@jcar87
Copy link
Contributor

jcar87 commented Jan 20, 2025

Please remember to add to config.yml as well, otherwise it's not exported, thanks :)

@kambala-decapitator
Copy link
Contributor Author

Please remember to add to config.yml as well, otherwise it's not exported, thanks :)

oops, my bad. Done, thank you!

@@ -69,7 +69,7 @@ def validate(self):
raise ConanInvalidConfiguration(f"{self.ref} shared is not supported with Visual Studio")

def build_requirements(self):
self.tool_requires("cmake/[>=3.16 <4]")
self.tool_requires("cmake/[>=3.17 <4]")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a pitty that the current recipe plays around with the generated library name for debug instead of expressing it in the package_info, but this has nothing to do with the current recipe, thanks a lot @kambala-decapitator!

Copy link
Contributor

@ErniGH ErniGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@jcar87 jcar87 merged commit 5e8d7f8 into conan-io:master Jan 21, 2025
9 checks passed
@kambala-decapitator kambala-decapitator deleted the package/sdl_ttf branch January 21, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants