Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fltk: add version 1.4.1 #26083

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fltk: add version 1.4.1 #26083

wants to merge 4 commits into from
+39 −19

Conversation

toge
Copy link
Contributor

@toge toge commented Dec 2, 2024 •
edited
Loading

Summary

Changes to recipe: fltk/1/4.1

Motivation

There are lots of new features in 1.4.1.

Try to close #26041.

Details

fltk/fltk@release-1.3.9...release-1.4.1

@ErniGH ErniGH self-assigned this Dec 2, 2024
ErniGH
ErniGH approved these changes Dec 2, 2024
View reviewed changes
recipes/fltk/all/conanfile.py
Comment on lines +165 to +166
if Version(self.version) >= "1.4.0":
self.cpp_info.system_libs.append("ws2_32")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @toge, that variable is only being used in the case of Win32 here could you help me better understand this? 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ws2_32 is added to FLTK_LDLIBS. link
FLTK_LDLIBS is used to generate LIBS variables. link
LIBS variable is used in fltk-config.in.

In hand install situation, fltk-config is used to compile and link user program. (ex. g++ fltk-config --libs xxx.cpp)

ErniGH
ErniGH requested changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@ErniGH ErniGH left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I misclick with the approval 😄

@toge toge changed the title fltk: add version 1.4.0 fltk: add version 1.4.1 Dec 15, 2024
ErniGH
ErniGH previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@ErniGH ErniGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks for the explanation!

@d-musique
Copy link

Thanks, I'm interested in this package too, but at first look I believe there will be problems.
Most cmake options are renamed in FLTK 1.4.

This document has a list of the name changes:
https://www.fltk.org/doc-1.4/migration_1_4.html#migration_1_4_modern_cmake

@toge
Copy link
Contributor Author

toge commented Jan 8, 2025

@d-musique
Thanks for review!
I will fix these problems soon.

@toge toge marked this pull request as draft January 8, 2025 10:37
@toge
Copy link
Contributor Author

toge commented Jan 10, 2025

@d-musique
I fixed. Could you review it again?

@toge toge marked this pull request as ready for review January 10, 2025 07:39
@d-musique
Copy link

I fixed. Could you review it again?

No because I'm not a reviewer, just a tourist passing by 😺
but I agree with those changes.

@toge
Copy link
Contributor Author

toge commented Jan 10, 2025

@d-musique
I know.
Thank you for spending your time to check it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErniGH ErniGH ErniGH left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@ErniGH ErniGH

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[request] fltk/1.4.0
3 participants
@toge @d-musique @ErniGH