-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[qcustomplot] Use version range for Qt #25423
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Uilian Ries <[email protected]>
@uilianries Did you see #25405? |
@valgur Nope, sorry. We are in middle of a maintenance, so I'm not checking PRs. I triggered your PR now to be built, if it passes at first build, I'll close mine, then we merge yours. Thank you! |
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Conan v1 pipeline ✔️All green in build 4 (
Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping Failure in build 4 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check CI results for missing binaries
Signed-off-by: Uilian Ries <[email protected]>
…nter-index into qcustomplot/qt-range
Totally cosmetic and optional, but I'd suggest something like this for the ~30 recipes using Qt: |
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
The current pre-checks results have the follow output: https://github.com/conan-io/conan-center-index/pull/25423/checks?check_run_id=36662334371
|
Updated binaries should now be present |
The latest CI check result looks much better: https://github.com/conan-io/conan-center-index/pull/25423/checks?check_run_id=36839729054 Only Qt5 is missing in two cases, but is related to libmysqlclient package. |
Summary
Changes to recipe: qcustomplot/2.1.1
Motivation
The maintained version of Qt-5 is 5.15.14, resulting in missing binary packages when building this package. Using version ranges for Qt solves the current error.