Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xqilla: add package_type, transitive_headers=True #25409

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Sep 25, 2024

Summary

Changes to recipe: xqilla/2.3.4

Motivation

One of the few remaining recipes that still lack Conan 2.x support.

Details

I bumped xerces-c as well due to v2.3.2 having 2 CVEs: https://repology.org/project/xerces-c/cves?version=3.2.3

Also added two patches for C++17 and later issues:

  • Missing const required for a comparison operator.
  • register keyword use, which is an error in C++20 and newer.

test_package fails to link when transitive_libs is False for xerces-c.


@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor

SpaceIm commented Sep 25, 2024

I've opened #17332 long time ago, but due to disagreement with conan team (they didn't want patches fixing compilation with C++17 or higher) I've closed it. Feel free to cherry pick some commits.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 664cc90
xqilla/2.3.4@#68428c2d11a98a26d9ee73cfbb2b2fac
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libxqilla.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot conan-center-bot added the Missing dependencies Build failed due missing dependencies in Conan Center label Oct 11, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

Failure in build 3 (10143609d00bb7df5a3bebcc02ff92498b541c34):

  • xqilla/2.3.4:
    CI failed to create some packages (All logs)

    Logs for packageID 1cf1f6ac94a642a531275850a76fa6cf8332e319:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    xqilla:shared=True
    
    [...]
    autoconf/2.71: Trying with 'conan-center'...
    Downloading conanmanifest.txt
    Downloading conanfile.py
    Downloading conan_export.tgz
    autoconf/2.71: Downloaded recipe revision f9307992909d7fb3df459340f1932809
    m4/1.4.19: Not found in local cache, looking in remotes...
    m4/1.4.19: Trying with 'conan-center'...
    Downloading conanmanifest.txt
    Downloading conanfile.py
    Downloading conan_export.tgz
    m4/1.4.19: Downloaded recipe revision b38ced39a01e31fef5435bc634461fd2
    Installing package: xqilla/2.3.4
    Requirements
        xerces-c/3.2.5 from 'conan-center' - Downloaded
        xqilla/2.3.4 from local cache - Cache
    Packages
        xerces-c/3.2.5:6dff0ee24b43c70fb90c38f54c17e80a48d22221 - Missing
        xqilla/2.3.4:1cf1f6ac94a642a531275850a76fa6cf8332e319 - Build
    Build requirements
        autoconf/2.71 from 'conan-center' - Downloaded
        automake/1.16.5 from 'conan-center' - Downloaded
        gnu-config/cci.20210814 from 'conan-center' - Downloaded
        libtool/2.4.7 from 'conan-center' - Downloaded
        m4/1.4.19 from 'conan-center' - Downloaded
    Build requirements packages
        autoconf/2.71:5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9 - Download
        automake/1.16.5:258f6f05ca54813b3d7180161753df7f9ccf7e1d - Download
        gnu-config/cci.20210814:5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9 - Download
        libtool/2.4.7:00ffeae55ec276f0fef26ad0ed5cd0191ca724ce - Download
        m4/1.4.19:24647d9fe8ec489125dfbae4b3ebefaf7581674c - Download
    
    Installing (downloading, building) binaries...
    
    WARN: **************************************************
    WARN: *** Conan 1 is legacy and on a deprecation path **
    WARN: *********** Please upgrade to Conan 2 ************
    WARN: **************************************************
    ERROR: Missing binary: xerces-c/3.2.5:6dff0ee24b43c70fb90c38f54c17e80a48d22221
    xerces-c/3.2.5: WARN: Can't find a 'xerces-c/3.2.5' package for the specified settings, options and dependencies:
    - Settings: arch=x86_64, build_type=Release, compiler=gcc, compiler.libcxx=libstdc++11, compiler.version=11, os=Linux
    - Options: char_type=uint16_t, fPIC=True, message_loader=inmemory, mutex_manager=posix, network=True, network_accessor=socket, shared=False, transcoder=gnuiconv
    - Dependencies: 
    - Requirements: 
    - Package ID: 6dff0ee24b43c70fb90c38f54c17e80a48d22221
    
    ERROR: Missing prebuilt package for 'xerces-c/3.2.5'
    Use 'conan search xerces-c/3.2.5@ --table=table.html -r=remote' and open the table.html file to see available packages
    Or try to build locally from sources with '--build=xerces-c'
    
    More Info at 'https://docs.conan.io/en/latest/faq/troubleshooting.html#error-missing-prebuilt-package'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 4 (10143609d00bb7df5a3bebcc02ff92498b541c34):

  • xqilla/2.3.4:
    CI failed to create some packages (All logs)

    Logs for packageID a81abf7f47ca50dcee18cce5af07923d2a1aba4a:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.cppstd=17
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=False
    
    [...]
    xqilla/2.3.4 (test package): Test package build folder: /home/conan/workspace/prod-v2/bsr/cci-01f32c0f/recipes/xqilla/all/test_package/build/gcc-11-x86_64-17-release
    xqilla/2.3.4 (test package): Writing generators to /home/conan/workspace/prod-v2/bsr/cci-01f32c0f/recipes/xqilla/all/test_package/build/gcc-11-x86_64-17-release/generators
    xqilla/2.3.4 (test package): Generator 'CMakeToolchain' calling 'generate()'
    xqilla/2.3.4 (test package): CMakeToolchain generated: conan_toolchain.cmake
    xqilla/2.3.4 (test package): CMakeToolchain generated: /home/conan/workspace/prod-v2/bsr/cci-01f32c0f/recipes/xqilla/all/test_package/build/gcc-11-x86_64-17-release/generators/CMakePresets.json
    xqilla/2.3.4 (test package): CMakeToolchain generated: /home/conan/workspace/prod-v2/bsr/cci-01f32c0f/recipes/xqilla/all/test_package/CMakeUserPresets.json
    xqilla/2.3.4 (test package): Generator 'CMakeDeps' calling 'generate()'
    xqilla/2.3.4 (test package): CMakeDeps necessary find_package() and targets for your CMakeLists.txt
        find_package(xqilla)
        target_link_libraries(... xqilla::xqilla)
    xqilla/2.3.4 (test package): Generator 'VirtualRunEnv' calling 'generate()'
    xqilla/2.3.4 (test package): Generating aggregated env files
    xqilla/2.3.4 (test package): Generated aggregated env files: ['conanrun.sh', 'conanbuild.sh']
    
    ======== Testing the package: Building ========
    xqilla/2.3.4 (test package): Calling build()
    xqilla/2.3.4 (test package): Running CMake.configure()
    xqilla/2.3.4 (test package): RUN: cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="/home/conan/workspace/prod-v2/bsr/cci-01f32c0f/recipes/xqilla/all/test_package" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release" "/home/conan/workspace/prod-v2/bsr/cci-01f32c0f/recipes/xqilla/all/test_package"
    -- Using Conan toolchain: /home/conan/workspace/prod-v2/bsr/cci-01f32c0f/recipes/xqilla/all/test_package/build/gcc-11-x86_64-17-release/generators/conan_toolchain.cmake
    -- Conan toolchain: Defining architecture flag: -m64
    -- Conan toolchain: C++ Standard 17 with extensions OFF
    -- The CXX compiler identification is GNU 11.4.0
    -- Check for working CXX compiler: /usr/local/bin/c++
    -- Check for working CXX compiler: /usr/local/bin/c++ -- works
    -- Detecting CXX compiler ABI info
    -- Detecting CXX compiler ABI info - done
    -- Detecting CXX compile features
    -- Detecting CXX compile features - done
    -- Conan: Target declared 'xqilla::xqilla'
    -- Conan: Target declared 'XercesC::XercesC'
    -- Configuring done
    -- Generating done
    -- Build files have been written to: /home/conan/workspace/prod-v2/bsr/cci-01f32c0f/recipes/xqilla/all/test_package/build/gcc-11-x86_64-17-release
    
    xqilla/2.3.4 (test package): Running CMake.build()
    xqilla/2.3.4 (test package): RUN: cmake --build "/home/conan/workspace/prod-v2/bsr/cci-01f32c0f/recipes/xqilla/all/test_package/build/gcc-11-x86_64-17-release" -- -j3
    Scanning dependencies of target test_package
    [ 50%] Building CXX object CMakeFiles/test_package.dir/test_package.cpp.o
    [100%] Linking CXX executable test_package
    [100%] Built target test_package
    
    
    ======== Testing the package: Executing test ========
    xqilla/2.3.4 (test package): Running test()
    xqilla/2.3.4 (test package): RUN: xqilla -h
    /bin/sh: 1: xqilla: not found
    
    ERROR: xqilla/2.3.4 (test package): Error in test() method, line 25
    	self.run("xqilla -h", env="conanrun")
    	ConanException: Error 127 while executing
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@AbrilRBS AbrilRBS self-assigned this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Failed Missing dependencies Build failed due missing dependencies in Conan Center
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants