Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sole: add package_type #25395

Merged
merged 4 commits into from
Nov 26, 2024
Merged

sole: add package_type #25395

merged 4 commits into from
Nov 26, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Sep 24, 2024

Summary

Changes to recipe: lib/[version]

Motivation

Details


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AbrilRBS AbrilRBS self-assigned this Sep 25, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valgur just a heads-up. We stopped adding the package_type to header-only libraries until the new pipeline comes online (Super soon!), as we'll probably need to modify their package_id_mode to avoid missing binaries for them, and we want to do it all at once instead of PR by PR.

I'll keep yu updated on thatm, but for now the new PRs that just add a header-only package_type we can close (if I close anything that has something else that I miss, please do let me know/reopen!), but either way thanks a lot for taking the time to improve the recipes, we appreciate it!

@AbrilRBS AbrilRBS closed this Sep 25, 2024
@valgur
Copy link
Contributor Author

valgur commented Sep 25, 2024

@AbrilRBS Ok, sounds reasonable. I would have liked to see whether this specific one passes or fails in the CI, though, since it's one of the few remaining ones (#20992 (comment)) that has been nominally migrated, but has not been successfully built with the v2 pipeline. Maybe you can reopen?

@AbrilRBS AbrilRBS reopened this Sep 25, 2024
@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

The bot might take a bit to post the results as we're under maintenance currently, but seems to be failing with https://c3i.jfrog.io/c3i/misc-v2/summary.html?json=https://c3i.jfrog.io/c3i/misc-v2/logs/pr/25395/4-linux-gcc/sole/1.0.2//summary.json

@AbrilRBS AbrilRBS closed this Sep 25, 2024
@AbrilRBS
Copy link
Member

Ping me once it gets fixed so we can try again :)

@valgur
Copy link
Contributor Author

valgur commented Sep 26, 2024

@AbrilRBS I fixed the test_package issues. You can re-open.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 5 (13b9a2ee265f1caca7232dc0ea3c06243b65ded7):

  • sole/1.0.4:
    Built 5 packages out of 11 (All logs)

  • sole/1.0.2:
    Built 5 packages out of 11 (All logs)

  • sole/1.0.1:
    Built 5 packages out of 11 (All logs)

Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@perseoGI perseoGI merged commit 8fba7de into conan-io:master Nov 26, 2024
7 checks passed
OMGtechy pushed a commit to OMGtechy/conan-center-index that referenced this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants