-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sole: add package_type #25395
sole: add package_type #25395
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valgur just a heads-up. We stopped adding the package_type
to header-only
libraries until the new pipeline comes online (Super soon!), as we'll probably need to modify their package_id_mode to avoid missing binaries for them, and we want to do it all at once instead of PR by PR.
I'll keep yu updated on thatm, but for now the new PRs that just add a header-only package_type we can close (if I close anything that has something else that I miss, please do let me know/reopen!), but either way thanks a lot for taking the time to improve the recipes, we appreciate it!
@AbrilRBS Ok, sounds reasonable. I would have liked to see whether this specific one passes or fails in the CI, though, since it's one of the few remaining ones (#20992 (comment)) that has been nominally migrated, but has not been successfully built with the v2 pipeline. Maybe you can reopen? |
This comment has been minimized.
This comment has been minimized.
The bot might take a bit to post the results as we're under maintenance currently, but seems to be failing with https://c3i.jfrog.io/c3i/misc-v2/summary.html?json=https://c3i.jfrog.io/c3i/misc-v2/logs/pr/25395/4-linux-gcc/sole/1.0.2//summary.json |
Ping me once it gets fixed so we can try again :) |
@AbrilRBS I fixed the test_package issues. You can re-open. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Changes to recipe: lib/[version]
Motivation
Details