-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fmt: add version 11.0.0 #24482
fmt: add version 11.0.0 #24482
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating this project!
The version 11.x introduced the option FMT_UNICODE
that I think could added to the recipe too.
fmtlib/fmt@10.2.1...11.0.0#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR170
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@toge thanks a lot for taking the time to submit the fix upstream, I'm sure they really appreciate it! ❤️
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :)
Conan v1 pipeline ✔️All green in build 8 (
Conan v2 pipeline ✔️
All green in build 9 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for updating fmt, good catch by exposing /utf-8 for msvc.
Summary
Changes to recipe: fmt/11.0.0
Motivation
There are lots of update since 10.2.1.
Details
fmtlib/fmt@10.2.1...11.0.0
I deleted one line in test_package.cpp because it failed in gcc14 with c++20.
I already created PR about this issue.
Since this seems to be a rare case, I decided to delete this line without waiting for the merge.