-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pangolin: new recipe #23782
base: master
Are you sure you want to change the base?
pangolin: new recipe #23782
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 07b54b2pangolin/0.9.1@#235af94f33075e9328380b27be6797c2
|
Conan v1 pipeline ✔️All green in build 12 (
Conan v2 pipeline ✔️
All green in build 12 (
|
Hooks produced the following warnings for commit ae8f455pangolin/0.9.1@#280b504edc26f07ddf68fa79a2a63778
|
Tested at least 100 combinations with different options in macOS ARM and LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though there are excessive options available, it looks good to me
@jwillikers Would you be willing to provide the necessary second review for this PR? |
if self.options.get_safe("with_wayland"): | ||
# Wayland 1.20+ is not compatible as of v0.9.1 | ||
self.requires("wayland/1.19.0") | ||
self.requires("wayland-protocols/1.33") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since wayland-protocols
isn't a runtime dependency, most recipes incorporate it as a tool_requires
. Here is where xkbcommon
incorporates it. The downside to the tool_requires
approach is that the same version of the protocols isn't properly propagated across dependencies, which seems like something that should be consistent across projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valgur could you take a look at this?
Can we resolve this thread?
In that case, I'll try to merge this PR
Adds Pangolin: https://github.com/stevenlovegrove/Pangolin
Pangolin is a set of lightweight and portable utility libraries for prototyping 3D, numeric or video based programs and algorithms. It is used quite widely in the field of Computer Vision as a means to remove platform-specific boilerplate and make it easy to visualize data.