flac: ignore DLL_EXPORT define in export.h #23680
Conversation
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ✔️
All green in build 2 ( |
| @@ -56,6 +56,7 @@ def generate(self): | |||
| tc.variables["BUILD_EXAMPLES"] = False | |||
| tc.variables["BUILD_DOCS"] = False | |||
| tc.variables["BUILD_TESTING"] = False | |||
| tc.cache_variables["CMAKE_POLICY_DEFAULT_CMP0077"] = "NEW" | |||
There was a problem hiding this comment.
What specific error is it fixing? There is no information in the description.
There was a problem hiding this comment.
Added it just to be safe. It's almost boilerplate, so I did not see a need to point it out.
The project uses CMake version < 3.12. Without setting the policy, any option() values in CMakeLists.txt might not be overridden by Conan. Even if it has worked ok without it so far, it's bug-prone and can easily become an issue in new releases. It also tends to cause issues silently, if it does.
There was a problem hiding this comment.
It makes sense, found similar fix in other places.
The Windows export header checks both
FLAC__NO_DLLandDLL_EXPORT, but the latter overly broadly named define is only set by autotools and we are using the CMake to build the project.Fixes the
unresolved external symbol __imp_FLAC__stream_decoder_newetc errors due to conflictingDLL_EXPORTdefine being set in