(#23474) simdjson/3.9.1: remove unnecessary constraints #23502

Jie-Cheng · 2024-04-12T22:38:17Z

The existing recipe aborts building when gcc9 and libstdc++11 are used. But I tried manually building from source, simdjson works fine in this situation. And simdjson documentation says gcc9 and above should work too.

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

CLAassistant · 2024-04-12T22:38:22Z

All committers have signed the CLA.

Jie-Cheng · 2024-04-23T18:08:16Z

@RubenRBS could you take a look at this PR please?

Jie-Cheng · 2024-05-27T06:20:49Z

@RubenRBS please take a look

AbrilRBS · 2024-05-27T13:57:28Z

Hi @Jie-Cheng - Sorry that this took so long to get addressed. As you can read from the message that the bot posted, for this PR to me mergeable, we need you to comment on this issue first :) I'll make sure to fast forward this PR once thats done!

Jie-Cheng · 2024-06-03T15:58:00Z

Hi @RubenRBS , I've gained access, could you take a look?

AbrilRBS

Hi @Jie-Cheng thanks a lot! Could you please provide successful compilation logs for the configuration you mention does work after removing these constrains? Thanks!

AbrilRBS

Hi @Jie-Cheng thanks a lot! Could you please provide successful compilation logs for the configuration you mention does work after removing these constrains? It helps inmensely for future maitenance and traceability :)
Thanks!

Jie-Cheng · 2024-06-04T06:50:07Z

Hi @Jie-Cheng thanks a lot! Could you please provide successful compilation logs for the configuration you mention does work after removing these constrains? It helps inmensely for future maitenance and traceability :) Thanks!

Hi @RubenRBS , how can I build the package using my updated recipe? I am in a docker env with gcc=9

AbrilRBS · 2024-06-06T16:03:55Z

Hi @RubenRBS , how can I build the package using my updated recipe? I am in a docker env with gcc=9

Hi @Jie-Cheng. Once you get your branch inside your docker container (either cloning it or sharing the volume works), you can navigate to the folder containing your conanfile.py and after running conan profile detect, run conan create . --version=3.9.1 -b=missing -s="build_type=Debug". The -s="build_type=Debug" bit will ensure you test with recipe in one of the now allowed modes. You'll also want to then re-create it changing that bit to -s="compiler.libcxx=libstdc++11 to check the other change.

Feel free to ping me once you have these logs, thanks!

Jie-Cheng · 2024-06-10T05:34:48Z

Hi @RubenRBS thanks for the help. Please check out the attached logs, where I built in debug and release modes respectively (both with libstdc++11).

debug.log
release.log

jcar87

Thanks @Jie-Cheng !

conan-center-bot · 2024-06-12T15:21:51Z

Conan v1 pipeline ✔️

All green in build 6 (6034f763bcde422a6a917b31fb0a26cfbc677ad0):

simdjson/3.3.0:
All packages built successfully! (All logs)
simdjson/3.9.1:
All packages built successfully! (All logs)
simdjson/3.9.2:
All packages built successfully! (All logs)
simdjson/3.7.0:
All packages built successfully! (All logs)
simdjson/3.6.4:
All packages built successfully! (All logs)
simdjson/3.9.3:
All packages built successfully! (All logs)
simdjson/3.8.0:
All packages built successfully! (All logs)
simdjson/3.2.0:
All packages built successfully! (All logs)
simdjson/3.5.0:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 6 (6034f763bcde422a6a917b31fb0a26cfbc677ad0):

simdjson/3.9.2:
All packages built successfully! (All logs)
simdjson/3.5.0:
All packages built successfully! (All logs)
simdjson/3.7.0:
All packages built successfully! (All logs)
simdjson/3.8.0:
All packages built successfully! (All logs)
simdjson/3.9.3:
All packages built successfully! (All logs)
simdjson/3.6.4:
All packages built successfully! (All logs)
simdjson/3.9.1:
All packages built successfully! (All logs)
simdjson/3.3.0:
All packages built successfully! (All logs)
simdjson/3.2.0:
All packages built successfully! (All logs)

…constraints

* upgrading to Conan 2 * clean yaml * removed from config.yml * Cleanup * use tool_requires * wip * (#24282) bump boost dependency * (#23502) (#23474) simdjson/3.9.1: remove unnecessary constraints * (#18680) kealib: migrate to Conan v2 * kealib: migrate to Conan v2 * kealib: transitive_libs=True * kealib: simplify patch * kealib: add v1.5.1 * kealib: bump hdf5 * kealib: add min cppstd check * kealib: require GCC 6+ * kealib: drop v1.4.13 * kealib: bump to 1.5.2 * kealib: bump to 1.4.15 * kealib: fix MSVC lib name * kealib: bump hdf5 * kealib: fix MSVC library names * kealib: set HDF5_THREADSAFE based on hdf5 option * kealib: restore GCC 5 support Co-authored-by: Uilian Ries <[email protected]> * kealib: fix a recipe bug * kealib: add CMAKE_POLICY_DEFAULT_CMP0077 * kealib: use valid_min_cppstd() * kealib: add cxx_std_11 to test_package * Add missing system lib in windows * Improve invalid config message. --------- Co-authored-by: Uilian Ries <[email protected]> Co-authored-by: Rubén Rincón Blanco <[email protected]> * (#19228) msix: migrate to Conan v2 * msix: migrate to Conan v2 * msix: use OpenSSL v1 * msix: bump deps * msix: fix Clang build issue * msix: fix OpenSSL 3 support * msix: add missing system libs * msix: simplify xml_parser option * msix: Clang 12 is not supported * msix: yaml * msix: test_package cxx_std_14 * (#24296) cpp-httplib: add version 0.16.0 * (#24297) glaze: add version 2.8.1 * (#24106) arrow: fix target names * Use the same CMake target names as upstream * Bugfix * Bugfix * Remove redundant calls to set_property("cmake_target_name") * Revert "Remove redundant calls to set_property("cmake_target_name")" This reverts commit fc113f0. * Bugfix * Bugfix * (#24307) libftp: add version 0.5.1 * (#24298) [sentry-native] Add versions 0.7.5/0.7.6 and remove 0.7.1/0.7.2 * (#24309) glaze: add version 2.8.2 * Update PULL_REQUEST_TEMPLATE.md (#24311) Update PR template: - Mention list of PRs by recipe - Simplify wording around testing locally - request that PRs are motivated and detailed (what/why/how) * (#24308) octo-logger-cpp: fix checksum for 1.12.0 * (#22456) proposal: update dependencies * proposal: update dependencies * Update recipes/proposal/all/conanfile.py * Update recipes/proposal/all/conanfile.py * Update recipes/proposal/all/conanfile.py * proposal: build fewer versions --------- Co-authored-by: Luis Caro Campos <[email protected]> * (#18949) userspace-rcu: migrate to Conan v2 * userspace-rcu: migrate to Conan v2 * userspace-rcu: add v0.14.0 * userspace-rcu: no need for a custom bootstrap script * userspace-rcu: fix test_v1_package * userspace-rcu: disable apple-clang for v0.11.4 * (#18986) librhash: migrate to Conan v2 * librhash: migrate to Conan v2 * librhash: use OpenSSL v1 * librhash: bump deps * librhash: fix installation * librhash: downgrade OpenSSL * librhash: switch to custom CMakeLists.txt The build scripts in the project are quite non-standard and not too portable. Based on rhash/RHash#103 * librhash: bump openssl * librhash: add v1.4.4 * librhash: fix the list of sources used in CMakeLists.txt * librhash: fix missing lib prefix for libs * librhash: don't use PROJECT_NAME * (#18950) pbc: migrate to Conan v2 * pbc: migrate to Conan v2 * pbc: bump gmp * pbc: use winflexbison on Windows * pbc: add transitive_headers=True to gmp * pbc: fix build * pbc: fix apple cross building bug * pbc: transitive_libs=True * pbc: bump deps * pbc: fix configure issue * pbc: fix to_apple_arch() * pbc: add MSVC support * pbc: add AutotoolsDeps workaround for MSVC * pbc: add MSVC ./configure workarounds * pbc: not compatible with MSVC due to use of GNU extensions * pbc: fix_apple_shared_install_name() * (#18948) hiredis/0.x.x: remove 0.x recipe * hiredis/0.x.x: migrate to Conan v2 * hiredis/0.x.x: fix_apple_shared_install_name(self) * Dropped support for very old 0.x.x versions --------- Co-authored-by: PerseoGI <[email protected]> * (#23997) mini: add recipe * mini: add recipe * Update recipes/mini/all/test_package/test_package.cpp --------- Co-authored-by: Luis Caro Campos <[email protected]> * (#24300) octo-logger-cpp: bumped fmt dependency * (#20586) pcre2: fix invalid pcre2-config output for static libs * pcre2: fix invalid pcre2-config output for static libs * pcre2: ignore noise from self.run() * pcre2: make pcre2-config test a bit more robust * pcre2: handle debug postfix correctly * pcre2: no need for win_bash = True * pcre2: drop self.tool_requires(self.tested_reference_str) * Update recipes/pcre2/all/test_package/conanfile.py * Update recipes/pcre2/all/test_package/conanfile.py * Update recipes/pcre2/all/test_package/conanfile.py * Update recipes/pcre2/all/test_package/conanfile.py * Update recipes/pcre2/all/test_package/conanfile.py * Update recipes/pcre2/all/test_package/conanfile.py * fix replace for 10.43 * fix fix replace --------- Co-authored-by: Daniel <[email protected]> * (#19239) pro-mdnsd: migrate to Conan v2 Co-authored-by: Carlos Zoido <[email protected]> * (#24262) reflect-cpp: add option for using with msgpack * reflect-cpp: add option for using with msgpack * reflect-cpp: fix with_msgpack option --------- Co-authored-by: Luis Caro Campos <[email protected]> * (#24011) arrow: add version 16.1.0 * arrow: add version 16.1.0 * Format build method --------- Co-authored-by: PerseoGI <[email protected]> * (#24312) [bot] Update authorized users list (2024-06-13) Co-authored-by: conan-center-bot <[email protected]> * (#24273) [boost] Add -fcoroutines for GCC10 only * Add -fcoroutines for GCC10 only Signed-off-by: Uilian Ries <[email protected]> * Use b2 ranged version Signed-off-by: Uilian Ries <[email protected]> --------- Signed-off-by: Uilian Ries <[email protected]> * (#24318) glaze: add version 2.8.4 * (#24316) jsoncons: add version 0.176.0 * (#24306) libmaxminddb: add version 1.10.0 * libmaxmind: add version 1.10.0 * add with_binaries option * Cleanups * append PATH on with_binaries=True --------- Co-authored-by: Rubén Rincón Blanco <[email protected]> * (#24323) pcre2: add version 10.44 * test pr do not merge * Revert "test pr do not merge" This reverts commit f146b96. * (#24328) change gn validate to validate_build * package license * update to set_property for cmake_build_modules * add library type --------- Signed-off-by: Uilian Ries <[email protected]> Co-authored-by: Rubén Rincón Blanco <[email protected]> Co-authored-by: Jean-Marco Alameddine <[email protected]> Co-authored-by: Jie Cheng <[email protected]> Co-authored-by: Martin Valgur <[email protected]> Co-authored-by: Uilian Ries <[email protected]> Co-authored-by: toge <[email protected]> Co-authored-by: Roberto Rossini <[email protected]> Co-authored-by: Martin Delille <[email protected]> Co-authored-by: Luis Caro Campos <[email protected]> Co-authored-by: PerseoGI <[email protected]> Co-authored-by: Daniel <[email protected]> Co-authored-by: Carlos Zoido <[email protected]> Co-authored-by: Beartama <[email protected]> Co-authored-by: Conan Center Index Bot <[email protected]> Co-authored-by: conan-center-bot <[email protected]>

(conan-io#23474) simdjson: remove unnecessary constraints

9746830

conan-center-bot added the User-approval pending label Apr 12, 2024

This comment has been minimized.

Sign in to view

prince-chrismc mentioned this pull request Apr 12, 2024

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

AbrilRBS self-assigned this Apr 15, 2024

Merge branch 'master' into master

beeffe3

This comment has been minimized.

Sign in to view

This was referenced May 8, 2024

simdjson: add version 3.9.2 #23915

Merged

[service] Potentially conflicting recipes #3571

Closed

Merge branch 'master' into master

1ba1be7

This comment has been minimized.

Sign in to view

Jie-Cheng mentioned this pull request May 28, 2024

[!!] Access request #4

Closed

uilianries mentioned this pull request May 31, 2024

[bot] Update authorized users list (2024-05-30) #24164

Merged

Merge branch 'master' into master

cd043f1

conan-center-bot removed the User-approval pending label Jun 3, 2024

This comment has been minimized.

Sign in to view

AbrilRBS reviewed Jun 3, 2024

View reviewed changes

jcar87 approved these changes Jun 12, 2024

View reviewed changes

jcar87 assigned jcar87 and unassigned AbrilRBS Jun 12, 2024

franramirez688 approved these changes Jun 12, 2024

View reviewed changes

Merge branch 'master' into master

6034f76

conan-center-bot added the Service Under Maintenance label Jun 12, 2024

This comment has been minimized.

Sign in to view

conan-center-bot removed the Service Under Maintenance label Jun 12, 2024

conan-center-bot merged commit 4815af8 into conan-io:master Jun 12, 2024
53 checks passed

memsharded pushed a commit to memsharded/conan-center-index that referenced this pull request Jun 14, 2024

(conan-io#23502) (conan-io#23474) simdjson/3.9.1: remove unnecessary …

e59a806

…constraints

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(#23474) simdjson/3.9.1: remove unnecessary constraints #23502

(#23474) simdjson/3.9.1: remove unnecessary constraints #23502

Jie-Cheng commented Apr 12, 2024

CLAassistant commented Apr 12, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

Jie-Cheng commented Apr 23, 2024

This comment has been minimized.

Jie-Cheng commented May 27, 2024

AbrilRBS commented May 27, 2024

Jie-Cheng commented Jun 3, 2024

This comment has been minimized.

AbrilRBS left a comment

AbrilRBS left a comment •

edited

Loading

Jie-Cheng commented Jun 4, 2024

AbrilRBS commented Jun 6, 2024

Jie-Cheng commented Jun 10, 2024

jcar87 left a comment

This comment has been minimized.

conan-center-bot commented Jun 12, 2024

(#23474) simdjson/3.9.1: remove unnecessary constraints #23502

(#23474) simdjson/3.9.1: remove unnecessary constraints #23502

Conversation

Jie-Cheng commented Apr 12, 2024

CLAassistant commented Apr 12, 2024 • edited Loading

This comment has been minimized.

This comment has been minimized.

Jie-Cheng commented Apr 23, 2024

This comment has been minimized.

Jie-Cheng commented May 27, 2024

AbrilRBS commented May 27, 2024

Jie-Cheng commented Jun 3, 2024

This comment has been minimized.

AbrilRBS left a comment

Choose a reason for hiding this comment

AbrilRBS left a comment • edited Loading

Choose a reason for hiding this comment

Jie-Cheng commented Jun 4, 2024

AbrilRBS commented Jun 6, 2024

Jie-Cheng commented Jun 10, 2024

jcar87 left a comment

Choose a reason for hiding this comment

This comment has been minimized.

conan-center-bot commented Jun 12, 2024

Conan v1 pipeline ✔️

Conan v2 pipeline ✔️

CLAassistant commented Apr 12, 2024 •

edited

Loading

AbrilRBS left a comment •

edited

Loading