-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#22661) openssl: fix handling of tc.defines in config_template #22662
Conversation
I detected other pull requests that are modifying openssl/3.x.x recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Just saw in the openssl/1.x.x conanfile.py that this has a slightly different format for handling the comma separation of defines. Should I update this PR with the following snippet so there is parity between the recipes for how this is handled?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much easier than the code used in the 1.x.x
recipe
Bug seems to exist since the 3.x.x
recipe was created, nice catch!
Hi! Sorry for the delay, I've scheduled this PR to be reviewed next monday, thanks for your patience :) |
@RubenRBS Any news on this PR? |
Hi @RubenRBS, is there anything that is blocking this from being reviewed? |
Conan v1 pipeline ✔️All green in build 1 (
Conan v2 pipeline ✔️
All green in build 1 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, after catching up with @uilianries we've agreed to push this forward :)
… in config_template
… in config_template
Specify library name and version: openssl/3.2.1
Fix the handling of tc.defines into the config_template for openssl. Currently, it is generating a single string that is space-separated, but the toolchain is expecting a comma-separated list of strings.
Fixes #22661