reflect-cpp: add version 0.10.0

[toge]

Specify library name and version: reflect-cpp/0.10.0

reflect-cpp/0.7.0 supports bson and cbor, but this PR does not mention the two features.
Since reflect-cpp is a header-library and these features do not require extra definitions or configuration files, I do not see the need to add two options for them.

For BSON support, you must also include the header <rfl/bson.hpp> and link to the libbson library (https://github.com/mongodb/libbson).
https://github.com/getml/reflect-cpp/blob/main/docs/bson.md

---

• I've read the contributing guidelines.
• I've used a recent Conan client version close to the currently deployed.
• I've tried at least one configuration locally with the conan-center hook activated.

[AbrilRBS]

I do not see the need to add two options for them.

@toge wouldn't we need to at the very least add the requirements to the recipe?

[RazielXYZ]

Anyone who would want to use them could just require them to their own project that uses reflect-cpp and wants those backends. Core reflect-cpp won't have issues compiling without the serialization libraries as backends unless you try to include its specific header for that format/backend.

That said, I'm not sure what the best practice is for something like this. When I made the initial recipe I thought having them in would be helpful, but in that case we should probably keep being consistent with having them.

Also, libbson in particular would be a bit awkward to require here, since it needs the newer one from mongo-c-driver, and the recipe for mongo-c-driver doesn't have a libbson-only option/mode.

[RazielXYZ]

@RubenRBS any thoughts on this?

[AbrilRBS]

Hi @RazielXYZ didn't realize you answered back, sorry for the delay, will have something for you tomorrow once I get back to reviewing PRs :)

[uilianries]

We have a similar recipe CCI with optional backend, so users need to include them as extra dependency. I would follow the same approach here, not installing these dependencies. Reading the headers and the cmake file, there is no mechanism like a ifdef or linkage that could break the project.

[RazielXYZ]

We have a similar recipe CCI with optional backend, so users need to include them as extra dependency. I would follow the same approach here, not installing these dependencies. Reading the headers and the cmake file, there is no mechanism like a ifdef or linkage that could break the project.

So the suggestion is to remove the with_* options and requires from the recipe? Sounds fine to me

[uilianries]

So the suggestion is to remove the with_* options and requires from the recipe? Sounds fine to me

Not exactly, let's keep with the current options to avoid breaking users.

[lkotsonis]

Should there be a separate PR for v0.8.0 that got out today?

[uilianries]

LGTM. We can take an action over the options in another PR.

[uilianries]

Should there be a separate PR for v0.8.0 that got out today?

@lkotsonis Yes, please. Could you open a new PR? Otherwise we would need to re-build this PR, but is actually good to be merged.

[toge]

oh.
In my local environment(17.7.2+d6990bcfa), it works fine.
I try to find workaround.

[lkotsonis]

oh. In my local environment(17.7.2+d6990bcfa), it works fine. I try to find workaround.

Any update on this?

[toge]

@RubenRBS
Colud you review it again?

If you think the options for dependand packages are mandatory(bson, toml, messagepack etc), I will add these options.

[franramirez688]

@toge Thanks a lot for the PR, it looks pretty well! Only one thing before moving this forward. We have to report that patch upstream and wait for the official solution to this bug. Otherwise, we could report it and add an extra step at validation time for that temporary invalid configuration while waiting for the official patch.

[toge]

@franramirez688
Thank you for your review.
I create a PR for this.
Let's wait for reply.

[toge]

@franramirez688
My patch has been merged.

[franramirez688]

@toge Great job! Thanks a lot for taking the time to report the patch upstream 👏 That's really appreciated.

[AbrilRBS]

Thanks for creating the upstream PR, it is supper appreciated! :)

[conan-center-bot]

Conan v1 pipeline ✔️

All green in build 12 (17a0c652ab4c31709a45d7cb6dd0556f5be5afbc):

• reflect-cpp/0.6.0:
  All packages built successfully! (All logs)

• reflect-cpp/0.10.0:
  All packages built successfully! (All logs)

---

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 11 (17a0c652ab4c31709a45d7cb6dd0556f5be5afbc):

• reflect-cpp/0.10.0:
  All packages built successfully! (All logs)

• reflect-cpp/0.6.0:
  All packages built successfully! (All logs)

[toge]

@RubenRBS
Colud you review it again?
I forgot to remove dangling patch.

[uilianries]

LGTM https://github.com/getml/reflect-cpp/compare/v0.6.0...v0.10.0.patch

[AbrilRBS]

Sorry for the delay! Looks great now