-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add with_asm and with_opencl options in the x264 recipe #22432
Conversation
Signed-off-by: Anthony Liot <[email protected]>
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping See details:Sorry, the build is only launched for Access Request users. You can request access writing in this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just two minor suggestions.
It's worth noting that the OpenCL feature does not require OpenCL libraries to be present. These are only loaded at runtime, if available.
PR is red due to a bug in the pipeline, but I have already sent a fix for it. I'll push this again when it is merged to get this PR to be merged. Thanks very much for your contribution, and sorry for the long delays to process this! |
Co-authored-by: memsharded <[email protected]>
Specify library name and version: libx264/cci.20220602
Add in the two options with_asm and with_opencl. When building on Android this two flags can be required.