Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add with_asm and with_opencl options in the x264 recipe #22432

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

anthonyliot
Copy link
Contributor

Specify library name and version: libx264/cci.20220602

Add in the two options with_asm and with_opencl. When building on Android this two flags can be required.


@CLAassistant
Copy link

CLAassistant commented Jan 19, 2024

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (5a399b06c8feff8f7097f728151cea7bfbf1a6a0):

  • libx264/20191217:
    All packages built successfully! (All logs)

  • libx264/cci.20220602:
    All packages built successfully! (All logs)

  • libx264/20190605:
    All packages built successfully! (All logs)


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

Copy link
Contributor

@valgur valgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two minor suggestions.

It's worth noting that the OpenCL feature does not require OpenCL libraries to be present. These are only loaded at runtime, if available.

@memsharded memsharded self-assigned this Nov 21, 2024
@memsharded
Copy link
Member

PR is red due to a bug in the pipeline, but I have already sent a fix for it. I'll push this again when it is merged to get this PR to be merged. Thanks very much for your contribution, and sorry for the long delays to process this!

@memsharded memsharded removed the null label Nov 21, 2024
@AbrilRBS AbrilRBS merged commit 3a396ec into conan-io:master Nov 22, 2024
9 checks passed
OMGtechy pushed a commit to OMGtechy/conan-center-index that referenced this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants