dbus: Add dbus_user option to allow specifying a different run user

[jwillikers]

Specify library name and version: dbus/*

Building dbus requires that the user specified for dbus_user exists.
To allow projects to build dbus in various situations, it makes sense to allow this option to be modified.

---

• I've read the contributing guidelines.
• I've used a recent Conan client version close to the currently deployed.
• I've tried at least one configuration locally with the conan-center hook activated.

[github-actions]

🤖 Beep Boop! This pull request is making changes to 'recipes/dbus//'.

👋 @jwillikers you might be interested. 😉

[ghost]

I detected other pull requests that are modifying dbus/1.x.x recipe:

• dbus: don't propagate X11 libs, drop with_glib, update license info #23384
• dbus/1.15.8: bump expat version to 2.6.0 #23137
• dbus: with_x11=True does not mean libdbus depends on xorg/system #22134
• Update conanfile.py #22094

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

[jwillikers]

Requires #22156

[jwillikers]

@RubenRBS @uilianries Can I get a review for this? Without it, local dbus builds are failing due to the messagebus group not being in the image.

Traceback (most recent call last):
  File "/root/.conan/data/dbus/1.15.8/_/_/build/f90ea84e722ce1012f8fe615de9d901f8ff1b350/src/meson_post_install.py", line 106, in <module>
    post_install_exe()
  File "/root/.conan/data/dbus/1.15.8/_/_/build/f90ea84e722ce1012f8fe615de9d901f8ff1b350/src/meson_post_install.py", line 95, in post_install_exe
    os.chown(exe_path, 0, grp.getgrnam(dbus_user).gr_gid)
KeyError: "getgrnam(): name not found: 'messagebus'"

It is also probably be worth opening an issue upstream to verify the group exists.

[AbrilRBS]

My main concern here is if this option changing the package id is desirable or not. Do you have any extra insight?

[jwillikers]

My main concern here is if this option changing the package id is desirable or not. Do you have any extra insight?

I'll check and see if the default user is compiled into the binary, in which case, it should effect the id.

[jwillikers]

Looks like it's only present in the system.conf file. The library itself doesn't contain any references: strings /home/jordan/.conan2/p/b/dbusbed52a0433957/p/lib/libdbus-1.a | grep -i messagebus was empty. No headers include it either. I'll remove the option in the package_id method.

[jwillikers]

Someone beat me to opening an issue upstream: https://gitlab.freedesktop.org/dbus/dbus/-/issues/492

[jwillikers]

Aha, the dbus maintainer recommends message_bus=false to disable the system related stuff, which would skip all of this.

[AbrilRBS]

sorry for the delay, i've finally got the time to follow up on this, and now that I've understood it, this looks like the best way to go, thanks a lot for following up on it :)

As for dbus beind dependend upon with snapshot versions, I'm super open to approve bump PR for those to the latest "LTS" ones if you want, else just let me know which ones and I can do that myself!

[franramirez688]

@jwillikers the PR has some conflicts.

[conan-center-bot]

Conan v1 pipeline ✔️

All green in build 11 (e66b1e36090ba678cd64e0cd266ee2ca694a0709):

• dbus/1.15.8:
  All packages built successfully! (All logs)

• dbus/1.15.2:
  All packages built successfully! (All logs)

• dbus/1.15.0:
  All packages built successfully! (All logs)

• dbus/1.15.6:
  All packages built successfully! (All logs)

[jwillikers]

@franramirez688 Done.