-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pcl: add v1.14.0, use llvm-openmp for OpenMP #22152
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we split the PR into the new version stuff, and the llvm-openmp one until we figure that one out?
Conan v1 pipeline ✔️Warning Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement. All green in build 23 (
Conan v2 pipeline ✔️
All green in build 23 ( |
@AbrilRBS Ok, I reverted most of the OpenMP-related changes. I only kept the use of more correct and robust OpenMP linker and cxx flags instead of adding it as a system lib (the name of which is not fixed on MSVC, for example). |
@valgur Hi, as a PCL user, thank you for your efforts in supporting conan. Looking at the above history, it seems that the check failed in the Pre-Checks step because of using the pre-release version of qhull. Is there a particular reason why you did not use version 8.0.1? |
The libqhull PR #24532 should be merged first. PCL links against the re-entrant libqhull_r library, but the libqhull recipe does not correctly distinguish between the reentrant and non-reentrant variants in package_info() currently. |
I scanned the diff against previous version and there were no changes to the list of components or their dependencies, either internal or external ones.