Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libspatialite: add v5.1.0, bump deps #21511

Merged
merged 7 commits into from
Mar 1, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Nov 30, 2023

Resolves #19111.

@valgur valgur changed the title spatialite: bump dependencies libspatialite: bump dependencies Nov 30, 2023
Copy link
Contributor

🤖 Beep Boop! This pull request is making changes to 'recipes/libspatialite//'.

👋 @jwillikers you might be interested. 😉

@AbrilRBS AbrilRBS self-assigned this Nov 30, 2023
AbrilRBS
AbrilRBS previously approved these changes Nov 30, 2023
@conan-center-bot

This comment has been minimized.

uilianries
uilianries previously approved these changes Dec 4, 2023
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@valgur valgur dismissed stale reviews from uilianries and AbrilRBS via cab195f December 4, 2023 08:02
@conan-center-bot conan-center-bot added the Missing dependencies Build failed due missing dependencies in Conan Center label Dec 4, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot removed the Missing dependencies Build failed due missing dependencies in Conan Center label Dec 5, 2023
@conan-center-bot

This comment has been minimized.

@valgur valgur force-pushed the update/libspatialite branch from 7faa4cf to cb47b2c Compare December 5, 2023 13:22
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur
Copy link
Contributor Author

valgur commented Dec 14, 2023

@uilianries Can you re-approve, please?

@conan-center-bot

This comment has been minimized.

@valgur valgur force-pushed the update/libspatialite branch from d0f1d7e to 9532e7a Compare December 26, 2023 21:38
@conan-center-bot

This comment has been minimized.

@valgur valgur changed the title libspatialite: bump dependencies libspatialite: add v5.1.0, bump deps Dec 27, 2023
@conan-center-bot

This comment has been minimized.

@valgur valgur force-pushed the update/libspatialite branch from 9532e7a to 06c07f7 Compare December 27, 2023 09:11
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 13 (9e575fce67bf3bb6a4e54792a4bd6c9224c3315a):

  • libspatialite/5.0.1:
    All packages built successfully! (All logs)

  • libspatialite/5.1.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 14 (9e575fce67bf3bb6a4e54792a4bd6c9224c3315a):

  • libspatialite/5.1.0:
    All packages built successfully! (All logs)

  • libspatialite/5.0.1:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

if self.options.get_safe("with_rttopo"):
self.requires("librttopo/1.1.0")
if self.options.with_libxml2:
self.requires("libxml2/2.10.3")
self.requires("libxml2/2.12.4")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GDAL uses libxml2/2.12.3. It will require another PR to align it. All other dependencies are aligned with GDAL requirements. Nice job.

@@ -192,14 +198,17 @@ def _build_msvc(self):
if not self.options.with_minizip:
replace_in_file(self, gaiaconfig_msvc, "#define ENABLE_MINIZIP 1", "")

# Workaround for a NMakeDeps define quoting issue:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Workaround for a NMakeDeps define quoting issue:
# Workaround for a NMakeDeps define quoting issue. Fixed in Conan 1.63 and 2.0.15

So we can remember in the future to be removed. It's still a fresh bugfix.

@uilianries uilianries self-assigned this Mar 1, 2024
@conan-center-bot conan-center-bot merged commit 1c888e8 into conan-io:master Mar 1, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants