-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libspatialite: add v5.1.0, bump deps #21511
Conversation
🤖 Beep Boop! This pull request is making changes to 'recipes/libspatialite//'. 👋 @jwillikers you might be interested. 😉 |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7faa4cf
to
cb47b2c
Compare
This comment has been minimized.
This comment has been minimized.
cb47b2c
to
6f2d4a1
Compare
This comment has been minimized.
This comment has been minimized.
@uilianries Can you re-approve, please? |
This comment has been minimized.
This comment has been minimized.
d0f1d7e
to
9532e7a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
9532e7a
to
06c07f7
Compare
This comment has been minimized.
This comment has been minimized.
06c07f7
to
9e575fc
Compare
Conan v1 pipeline ✔️All green in build 13 (
Conan v2 pipeline ✔️
All green in build 14 ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
if self.options.get_safe("with_rttopo"): | ||
self.requires("librttopo/1.1.0") | ||
if self.options.with_libxml2: | ||
self.requires("libxml2/2.10.3") | ||
self.requires("libxml2/2.12.4") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GDAL uses libxml2/2.12.3. It will require another PR to align it. All other dependencies are aligned with GDAL requirements. Nice job.
@@ -192,14 +198,17 @@ def _build_msvc(self): | |||
if not self.options.with_minizip: | |||
replace_in_file(self, gaiaconfig_msvc, "#define ENABLE_MINIZIP 1", "") | |||
|
|||
# Workaround for a NMakeDeps define quoting issue: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Workaround for a NMakeDeps define quoting issue: | |
# Workaround for a NMakeDeps define quoting issue. Fixed in Conan 1.63 and 2.0.15 |
So we can remember in the future to be removed. It's still a fresh bugfix.
Resolves #19111.