ncurses: migrate to Conan v2 #20355

valgur · 2023-10-04T20:07:25Z

Some notable changes:

Moved the definition of the compatibility CMake module to an external file.
Condensed the component definitions in package_info().
Added an unofficial Curses::Curses CMake target. CMake currently does not set one (https://gitlab.kitware.com/cmake/cmake/-/issues/23051), but I think having it is helpful and much less error-prone than using package variables.

These can probably be closed if this PR gets merged:

Resolves [ncurses] Add conan 2.0 compatibility #17805
Resolves updates ncurses to conanv2 #18568
Resolves [package] ncurses/6.3: Cannot Import Package for Conan 2.0 #16627
Resolves [package] ncurses/6.4: Seems to not be conan2 compatible #20084

ghost · 2023-10-04T20:13:57Z

I detected other pull requests that are modifying ncurses/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

github-actions · 2023-10-16T13:40:56Z

Hooks produced the following warnings for commit e08332d

ncurses/6.3@#9c8ff067110359ed333d2451b482ab65

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libncurses++w.so' links to system library 'util' but it is not in cpp_info.system_libs.

To fix the 'undefined symbol: _ZNSt3__14cerrE' error when using the shared lib with libc++.

uilianries · 2023-11-17T09:08:12Z

recipes/ncurses/all/conanfile.py

-        "with_ticlib": ["auto", True, False],
+        "with_ticlib": [True, False],
        "with_reentrant": [True, False],
-        "with_tinfo": ["auto", True, False],
+        "with_tinfo": [True, False],


Please, inform how do you change these values in term of always True, but considering that the system will actually do a check to enable/disable first.

I restored the "auto" default value for clarity and backwards compatibility.

…tibility

recipes/ncurses/all/conanfile.py

uilianries · 2023-11-28T16:11:48Z

recipes/ncurses/all/cmake/conan-official-ncurses-targets.cmake

Okay, I checked https://cmake.org/cmake/help/latest/module/FindCurses.html and this file follows the variables there.

AbrilRBS · 2023-11-28T16:18:06Z

I've tested locally with these combinations which seem to work:

9   conan create . --version=6.3 -o "&:with_pcre2=True" --build=missing -c:h "tools.files.download:verify=False" -c:b "tools.files.download:verify=False"
10  conan create . --version=6.3 -o "&:with_pcre2=True" --build=missing -c:h "tools.files.download:verify=False" -c:b "tools.files.download:verify=False" -o "*/*:shared=True"
11  conan create . --version=6.3 -o "&:with_pcre2=True" --build=missing -c:h "tools.files.download:verify=False" -c:b "tools.files.download:verify=False" -o "*/*:shared=True" -o "&:with_reentrant=True"
12  conan create . --version=6.3 -o "&:with_pcre2=True" --build=missing -c:h "tools.files.download:verify=False" -c:b "tools.files.download:verify=False" -o "*/*:shared=True" -o "&:with_reentrant=True" -o "&:with_progs=False"

AbrilRBS

Question about the handling of with_ticlib, looks good otherwise :)

AbrilRBS · 2023-11-29T14:04:57Z

recipes/ncurses/all/conanfile.py


    def config_options(self):
        if self.settings.os == "Windows":
            del self.options.fPIC
+        # Set the default value based on OS
+        self.options.with_ticlib = self.settings.os != "Windows"


This is overriding whatever the user is setting these options as even if they are not set to auto, right?

I see #20355 (comment) but not clear to me what the correct way would be

This only overwrites the default "auto" value with a correct OS-specific default value. User-specified values for these options are not affected.

Believe me, this is approach is positively fantastic and I'm glad it works. Any alternatives approaches would need an insane amount of hacking around self.options and self.info.options being expected in different methods.

uilianries · 2023-11-30T12:20:17Z

@valgur Could you please add test_v1_package too. It's missing and this recipe is not a new one.

valgur · 2023-11-30T12:41:10Z

@valgur Could you please add test_v1_package too. It's missing and this recipe is not a new one.

@uilianries test_v1_package turned out to be too much of a headache for the included .cmake module with different naming conventions and what not used in the old generators. It will probably fail when using the custom CMake variables as is done in the test_package CMakeLists.txt, but would work just fine with a normal CMake target. Not worth the extra effort, IMO.

uilianries · 2023-11-30T14:20:02Z

@valgur Could you please add test_v1_package too. It's missing and this recipe is not a new one.

@uilianries test_v1_package turned out to be too much of a headache for the included .cmake module with different naming conventions and what not used in the old generators. It will probably fail when using the custom CMake variables as is done in the test_package CMakeLists.txt, but would work just fine with a normal CMake target. Not worth the extra effort, IMO.

@valgur no problem! Thank you for trying, let's keep only test_package then.

uilianries

LGTM

conan-center-bot · 2023-12-01T16:53:19Z

Conan v1 pipeline ✔️

All green in build 38 (17cf0eba5ef1325c380084cf7f9a87ac00eec9ad):

ncurses/6.3:
All packages built successfully! (All logs)
ncurses/6.4:
All packages built successfully! (All logs)
ncurses/6.2:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 38 (17cf0eba5ef1325c380084cf7f9a87ac00eec9ad):

ncurses/6.4:
All packages built successfully! (All logs)
ncurses/6.3:
All packages built successfully! (All logs)
ncurses/6.2:
All packages built successfully! (All logs)

This was referenced Oct 4, 2023

[service] Potentially conflicting recipes #3571

Closed

updates ncurses to conanv2 #18568

Closed

prince-chrismc mentioned this pull request Oct 4, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

conan-center-bot added the Failed label Oct 4, 2023

This comment has been minimized.

Sign in to view

ghost mentioned this pull request Oct 18, 2023

[ncurses] Add conan 2.0 compatibility #17805

Closed

3 tasks

valgur force-pushed the migrate/ncurses branch from 1f18ec1 to f9c3edc Compare October 24, 2023 19:32

samuel-emrys mentioned this pull request Oct 26, 2023

Cpython #20768

Closed

valgur force-pushed the migrate/ncurses branch from f9c3edc to f6352b3 Compare October 27, 2023 09:36

This comment has been minimized.

Sign in to view

valgur force-pushed the migrate/ncurses branch from fcb2221 to 3c6e2ef Compare November 2, 2023 12:27

This comment has been minimized.

Sign in to view

valgur added 8 commits November 2, 2023 17:13

ncurses: migrate to Conan v2

f025797

ncurses: fix Conan v1 compatibility

dab0101

ncurses: fix linter error

1f0acd6

ncurses: add "util" from libc as a system dependency

4c09630

ncurses: update MSVC version check

5fdc5dd

ncurses: add libcxx to system_libs

2a28dd3

To fix the 'undefined symbol: _ZNSt3__14cerrE' error when using the shared lib with libc++.

ncurses: add automake dependency

a91030a

ncurses: remove -nologo

b0c8167

conan-center-bot added the Failed label Nov 16, 2023

This comment has been minimized.

Sign in to view

conan-center-bot removed the Failed label Nov 17, 2023

This comment has been minimized.

Sign in to view

uilianries reviewed Nov 17, 2023

View reviewed changes

valgur added 3 commits November 17, 2023 15:35

ncurses: set env var in generator

9918883

ncurses: fix options handling

d76664a

ncurses: restore "auto" option values for clarity and backwards-compa…

7c4d860

…tibility

valgur force-pushed the migrate/ncurses branch from deade1c to 7c4d860 Compare November 17, 2023 13:36

conan-center-bot added the Failed label Nov 17, 2023

This comment has been minimized.

Sign in to view

Ahajha reviewed Nov 22, 2023

View reviewed changes

recipes/ncurses/all/conanfile.py Show resolved Hide resolved

ncurses: fix -FS not being applied on Conan v1

17cf0eb

conan-center-bot removed the Failed label Nov 22, 2023

This comment has been minimized.

Sign in to view

uilianries reviewed Nov 28, 2023

View reviewed changes

AbrilRBS reviewed Nov 29, 2023

View reviewed changes

uilianries previously approved these changes Nov 30, 2023

View reviewed changes

valgur dismissed uilianries’s stale review via 17cf0eb November 30, 2023 15:25

valgur force-pushed the migrate/ncurses branch from 386cfc0 to 17cf0eb Compare November 30, 2023 15:25

valgur requested a review from uilianries November 30, 2023 15:25

AbrilRBS approved these changes Nov 30, 2023

View reviewed changes

samuel-emrys approved these changes Dec 1, 2023

View reviewed changes

conan-center-bot merged commit e149e57 into conan-io:master Dec 2, 2023
27 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ncurses: migrate to Conan v2 #20355

ncurses: migrate to Conan v2 #20355

valgur commented Oct 4, 2023 •

edited

Loading

ghost commented Oct 4, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 16, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

uilianries Nov 17, 2023

valgur Nov 17, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

uilianries Nov 28, 2023

AbrilRBS commented Nov 28, 2023 •

edited

Loading

AbrilRBS left a comment

AbrilRBS Nov 29, 2023

AbrilRBS Nov 29, 2023

valgur Nov 29, 2023

uilianries commented Nov 30, 2023

valgur commented Nov 30, 2023

uilianries commented Nov 30, 2023

uilianries left a comment

conan-center-bot commented Dec 1, 2023

ncurses: migrate to Conan v2 #20355

ncurses: migrate to Conan v2 #20355

Conversation

valgur commented Oct 4, 2023 • edited Loading

ghost commented Oct 4, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 16, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

uilianries Nov 17, 2023

Choose a reason for hiding this comment

valgur Nov 17, 2023

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

uilianries Nov 28, 2023

Choose a reason for hiding this comment

AbrilRBS commented Nov 28, 2023 • edited Loading

AbrilRBS left a comment

Choose a reason for hiding this comment

AbrilRBS Nov 29, 2023

Choose a reason for hiding this comment

AbrilRBS Nov 29, 2023

Choose a reason for hiding this comment

valgur Nov 29, 2023

Choose a reason for hiding this comment

uilianries commented Nov 30, 2023

valgur commented Nov 30, 2023

uilianries commented Nov 30, 2023

uilianries left a comment

Choose a reason for hiding this comment

conan-center-bot commented Dec 1, 2023

Conan v1 pipeline ✔️

Conan v2 pipeline ✔️

valgur commented Oct 4, 2023 •

edited

Loading

AbrilRBS commented Nov 28, 2023 •

edited

Loading