Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpng: use version range for zlib #19648

Closed
wants to merge 1 commit into from

Conversation

ericLemanissier
Copy link
Contributor

Specify library name and version: libpng/*


@ericLemanissier
Copy link
Contributor Author

ericLemanissier commented Sep 7, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

🤖 Beep Boop! This pull request is making changes to 'recipes/libpng//'.

👋 @Hopobcn you might be interested. 😉

@ericLemanissier ericLemanissier mentioned this pull request Sep 7, 2023
3 tasks
@ghost
Copy link

ghost commented Sep 7, 2023

I detected other pull requests that are modifying libpng/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor

SpaceIm commented Sep 7, 2023

libpng: use version range for glib

You mean for zlib?

@ericLemanissier ericLemanissier changed the title libpng: use version range for glib libpng: use version range for zlib Sep 7, 2023
@ericLemanissier
Copy link
Contributor Author

Yes, thanks!

@ghost ghost mentioned this pull request Sep 8, 2023
3 tasks
@AbrilRBS
Copy link
Member

AbrilRBS commented Sep 8, 2023

Hi @ericLemanissier thanks a lot for your contribution.

In order to avoid missing binaries & conflicts, we're holding off from merging zlib bumps to versions ranges. We are handling this internally and will create the appropriate PRs in order.
(See the note in here)

When it's time for this recipe to be merged, we'll use this PR to keep your contribution, and we'll take care of the rest of the recipes, no need to open new PRs with them :)

@AbrilRBS AbrilRBS marked this pull request as draft September 8, 2023 11:18
@ericLemanissier ericLemanissier deleted the patch-3 branch September 8, 2023 11:37
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (f4efdbf684eb23a14f3c05547fcb77092b6dd0e9):

  • libpng/1.6.38:
    All packages built successfully! (All logs)

  • libpng/1.6.39:
    All packages built successfully! (All logs)

  • libpng/1.6.40:
    All packages built successfully! (All logs)

  • libpng/1.6.37:
    All packages built successfully! (All logs)

  • libpng/1.5.30:
    All packages built successfully! (All logs)

  • libpng/1.6.32:
    All packages built successfully! (All logs)


Conan v2 pipeline ❌

Regression: Conan v2 builds are mandatory and they are required for the PR to be merged, because this recipe worked with Conan v2 previously.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 1 (f4efdbf684eb23a14f3c05547fcb77092b6dd0e9):

  • libpng/1.6.32:
    CI failed to create some packages (All logs)

    Logs for packageID 19b397f6e54f5b8b2c6f7b81c4dce4c52d386e4f:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.cppstd=17
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=False
    
    [...]
    */*:shared=False
    [conf]
    tools.system.package_manager:mode=install
    tools.system.package_manager:sudo=True
    
    Profile build:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.cppstd=17
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [conf]
    tools.system.package_manager:mode=install
    tools.system.package_manager:sudo=True
    
    
    ======== Computing dependency graph ========
    zlib/1.3: Not found in local cache, looking in remotes...
    zlib/1.3: Checking remote: conan-center
    zlib/1.3: Downloaded recipe revision 06023034579559bb64357db3a53f88a4
    Graph root
        cli
    Requirements
        libpng/1.6.32#cbed49ef545a0d723ec28649615ed5f5 - Cache
        zlib/1.3#06023034579559bb64357db3a53f88a4 - Downloaded (conan-center)
    Resolved version ranges
        zlib/[>=1.2.10 <2]: zlib/1.3
    
    ======== Computing necessary packages ========
    libpng/1.6.32: Forced build from source
    Requirements
        libpng/1.6.32#cbed49ef545a0d723ec28649615ed5f5:19b397f6e54f5b8b2c6f7b81c4dce4c52d386e4f - Build
        zlib/1.3#06023034579559bb64357db3a53f88a4:b647c43bfefae3f830561ca202b6cfd935b56205#9f51ace6f715101c7daf0f943c803d69 - Download (conan-center)
    
    ======== Installing packages ========
    
    -------- Downloading 1 package --------
    zlib/1.3: Retrieving package b647c43bfefae3f830561ca202b6cfd935b56205 from remote 'conan-center' 
    zlib/1.3: Package installed b647c43bfefae3f830561ca202b6cfd935b56205
    zlib/1.3: Downloaded package revision 9f51ace6f715101c7daf0f943c803d69
    libpng/1.6.32: Calling source() in /home/conan/w/prod-v2/bsr/3591/ffbda/p/libpn1fe7f8fb7642b/s/src
    libpng/1.6.32: WARN: File https://sourceforge.net/projects/libpng/files/libpng16/older-releases/1.6.32/libpng-1.6.32.tar.xz not found in https://c3i.jfrog.io/artifactory/conan-center-backup-sources/
    ERROR: libpng/1.6.32: Error in source() method, line 102
    	get(self, **self.conan_data["sources"][self.version], strip_root=True)
    	ConanException: sha256 signature failed for 'c918c3113de74a692f0a1526ce881dc26067763eb3915c57ef3a0f7b6886f59b' file. 
     Provided signature: c918c3113de74a692f0a1526ce881dc26067763eb3915c57ef3a0f7b6886f59b  
     Computed signature: 251a85b3bac687974f360d3796048c20ded3bf0bd69e0d1cfd1db23d013f89ed
    
  • libpng/1.6.40:
    Didn't run or was cancelled before finishing

  • libpng/1.6.38:
    Didn't run or was cancelled before finishing

  • libpng/1.5.30:
    Didn't run or was cancelled before finishing

  • libpng/1.6.37:
    Didn't run or was cancelled before finishing

  • libpng/1.6.39:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants