-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add snitch 1.2.3 #19551
Add snitch 1.2.3 #19551
Conversation
This comment has been minimized.
This comment has been minimized.
I will add a patch to lower the minimum CMake version. That should fix the v1 pipeline. For the v2 pipeline, I don't know yet. Edit: I think the v2 issue can be solved by replacing |
This comment has been minimized.
This comment has been minimized.
For v1 pipeline: No idea at this stage. I will look at the logs further and see if I can replicate the error on my end. Edit: Yes, the For v2 pipeline: I don't know how this slipped through the cracks, but it seems my CMake scripts actually still require CMake 3.19 features. I will add more thorough tests with CMake 3.14, which is the advertised minimum version. Then patch or issue another release. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 55463d1snitch/1.2.2@#191bf06aca2e21318a49301d66ad79d3
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 10 (
Conan v2 pipeline ✔️
All green in build 10 ( |
Note: I have migrated the library from my personal GitHub account to a dedicated organization, to allow for more than one maintainer. Hence all the URLs have been updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@cschreib Thank you for your first contribution here in ConanCenterIndex! I see your recipe is looking real good. We still need one more positive review to be merged. More info about our review process: https://github.com/conan-io/conan-center-index/blob/master/docs/review_process.md |
Specify library name and version: snitch/1.2.3
Hi there, I am the author of this library and would like to contribute a recipe for it.