Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gdal: migrate to Conan v2 #19298

Merged
merged 113 commits into from
Feb 20, 2024
Merged

gdal: migrate to Conan v2 #19298

merged 113 commits into from
Feb 20, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Aug 19, 2023 •
edited
Loading

@ghost
Copy link

ghost commented Aug 19, 2023 •
edited by ghost
Loading

I detected other pull requests that are modifying gdal/post_3.5.0 recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

This was referenced Aug 19, 2023
Closed
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@AndreyMlashkin
Copy link
Contributor

depends on #19301

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur
Copy link
Contributor Author

valgur commented Aug 21, 2023

@uilianries Could you help with ERROR: Missing prebuilt package for 'lerc/4.0.0', please?

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@ghost ghost mentioned this pull request Aug 23, 2023
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur marked this pull request as ready for review September 7, 2023 23:06
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur closed this Sep 14, 2023
@valgur valgur reopened this Sep 14, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur mentioned this pull request Sep 16, 2023
Merged
3 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@AndreyMlashkin
Copy link
Contributor

@uilianries @SSE4 @RubenRBS
please, green before it's too late

@AndreyMlashkin
Copy link
Contributor

@RubenRBS @mayeut
could you please review? This one is opened in August, thats my last blocker to switch to conan v2

@AndreyMlashkin
Copy link
Contributor

@franramirez688 @uilianries @RubenRBS

This was referenced Feb 10, 2024
Closed
Open
@AndreyMlashkin
Copy link
Contributor

@franramirez688 @uilianries @RubenRBS @SSE4
it's already 20 days since the green build, could someone of you guys find some time for a review?

@uilianries uilianries mentioned this pull request Feb 12, 2024
Merged
3 tasks
uilianries
uilianries reviewed Feb 12, 2024
View reviewed changes
recipes/gdal/post_3.5.0/test_package/conanfile.py Show resolved Hide resolved
recipes/gdal/post_3.5.0/conanfile.py Show resolved Hide resolved
recipes/gdal/post_3.5.0/conanfile.py Outdated
Comment on lines 483 to 484
jsonc = self.dependencies["json-c"]
jsonc.cpp_info.includedirs.append(os.path.join(jsonc.package_folder, "include", "json-c"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created the PR #22752 to include the extra folder to json-c. Indeed gdal is correct in include that path directly.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 76 (0ee0384037af2e55762fa22e968a95f2df513c39):

  • gdal/3.7.3:
    All packages built successfully! (All logs)

  • gdal/3.5.3:
    All packages built successfully! (All logs)

  • gdal/3.8.3:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 76 (0ee0384037af2e55762fa22e968a95f2df513c39):

  • gdal/3.8.3:
    All packages built successfully! (All logs)

  • gdal/3.7.3:
    All packages built successfully! (All logs)

  • gdal/3.5.3:
    All packages built successfully! (All logs)

@trns1997 trns1997 mentioned this pull request Feb 16, 2024
Closed
@valgur
Copy link
Contributor Author

valgur commented Feb 20, 2024

Thank you for the review and the fixes @uilianries! Is there anything else you would like to review or change? All of the existing review comments seem to have been addressed for now.

uilianries
uilianries reviewed Feb 20, 2024
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I gonna ask @franramirez688 for a last review.

@uilianries
Copy link
Member

@valgur I see you are not listed as Community reviewer, so I would like to ask if we could add you, so any of your PR review will count to be merged. Actually, it was a mistake not asking you before.

franramirez688
franramirez688 approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👏

@conan-center-bot conan-center-bot merged commit a1c6c89 into conan-io:master Feb 20, 2024
23 checks passed
@valgur
Copy link
Contributor Author

valgur commented Feb 20, 2024

Whew, glad to see it finally merged. 😀 🎉

@uilianries Thank you for the offer! I would gladly help out as a community reviewer in any way I can.

@uilianries uilianries mentioned this pull request Feb 20, 2024
Merged
3 tasks
@valgur valgur mentioned this pull request Mar 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS left review comments

@uilianries uilianries uilianries left review comments

@trns1997 trns1997 trns1997 approved these changes

@mayeut mayeut mayeut approved these changes

@franramirez688 franramirez688 franramirez688 approved these changes

@AndreyMlashkin AndreyMlashkin AndreyMlashkin approved these changes

@SSE4 SSE4 SSE4 approved these changes

Assignees

@franramirez688 franramirez688

Labels
None yet
Projects
None yet
Milestone
No milestone